Including a SMIET Runner + parity issues between JAX & NumPy
Here most consistency issues between JAX and NumPy are matched, and a general SMIET runner is now implemented for end users to have easier accessibility of the code. This fixes #30 and #17 .
Additionally, the file storage optimisation is included in the coreas_to_hdf5_origin.py (Fixes #31 ) and this reduces the overall memory overhead in the jax version (Fixes #23 )
Syntactic changes between jax and numpy
- load / save both in hdf5
- removed seralize/deserliaze in SlicedSynthesis in favour of assigning antenna parameters directly (np)
- slice_grammages -> grammages (np)
- antenna-specific objects -> antenna_information (jax)
- freq_ar load without units.MHz (jax)
- store zenith / azimuth instead of geometry in tempalte_information (np)
- match template_information (jax)
- long -> long_profile (np)
- removed explicit GH parameters as members, and opt to set GH parameters as a dictionary object (jax)
- made SlicedShower object inherited from CoreasShower and moved repeating methods to CoreasShower (jax)
- renamed antenna properties to antenna_array like in numpy (jax)
- bandpass filter the traces on initialization for all shower objects (numpy & jax), since we anyways only work within that bandwidth
- included compression for heavy arrays when saving templates (numpy & jax)
- moved transformer object to base_shower, like in numpy (jax)
- call functions for antenna position match with numpy (jax)
- magnetic_field_vector -> magnet (jax)
- long_profile before returned both grammages & profile, now only returns profile and grammages set separately (numpy)
- GH_parmaeters now saved as dictionary, containing all parameters as well as L and R (numpy & jax)
- removed geometry, opting for zenith and azimuth as private members instead
- adding antenna labels from reconstructing starshape to have a geometry-independent way to get the function
- moved the transform_profile_to_origin to base shower
SMIET Runner
-
verified generation with user-defined target showers -
verified generation with coreas showers -
verify the jax implementation -
include function to extract synthesised traces from slices
Edited by Keito Watanabe