History

We need this MR to discuss details and technicalities of this branch.

The code approval procedure is described in the wiki: Code approval procedure wiki

• The MR is without WIP (work in progress) status
• Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
  • if "check clang-format" failed: the code contributor has to run ./do-clang-format.py --apply eventually with the --all option
  • if "check copyright" failed the code contributor has to run./do-copyright.py --add=20xy
• Make sure also the jobs with label ready for code review succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur
• Check in the "coverage" job output that the coverage did not decreases. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
• On the MR page, open the "Open in Web IDE" tool
  • Check if the provided solution solves the Issue, discuss on gitlab
  • Check that all changes are actually related to the issue
  • There are no debug statements left, not even commented out
  • Check all changes for coding rules and guidelines
• When all above is done:
  • Add MR label "Code Review Finished"

Framework/Cascade/History.h

-/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
- *
- * This software is distributed under the terms of the GNU General Public
- * Licence version 3 (GPL Version 3). See file LICENSE for a full version of
- * the license.
- */
-
-#include <memory>
-#include <utility>
-#include <variant>
-
-using ParticleCode = std::variant<corsika::particles::ParticleCode, std::pair<int, int>>;
-
-class SecondaryParticle {
-  corsika::units::si::HEPEnergyType const energy_;
-  corsika::geometry::Vector<corsika::units::si::hepmomentum_d> const momentum_;
-  ParticleCode const pid_;
-
-  // what else...?
-  // - polarization
-
-public:
-  SecondaryParticle(energy, momentum, pid)
-      : energy_{energy}
-      , momentum_{momentum}
-      , pid_{pid} {}
-};
-
-class Event; // forward declaration
-using EventPtr = std::shared_ptr<Event>;
-
-struct ProjectileParticle {
-  std::pair<EventPtr, size_t> origin;
-  corsika::geometry::Point position;
-  coriska::units::si::TimeType time;
-  corsika::geometry::Vector<corsika::units::si::hepmomentum_d> momentum;
-  corsika::units::si::HEPEnergyType energy;
-
-  // weight
-};
-
-struct Event {
-  corsika::particles::ParticleCode targetCode; // cannot be const...
-  ProjectileParticle projectile;
-
-  std::vector<SecondaryParticle> secondaries;
-};
-
-template <typename TStackView>
-class EventBuilder {
-  TStackView& stackView_;
-  EventPtr event_;
-
-public:
-  EventBuilder(TStackView& view)
-      : stackView_{stackView}
-      , event_{std::make_shared<Event>()} {}
-
-  template <typename... Args>
-  void AddSecondary(Args&&... args) {
-    auto const s = stackView.AddSecondary(std::forward<Args>(args), event);
-    event->secondaries.emplace_back(s.GetEnergy(), s.GetMomentum(), s.GetParticleID());
-  }
-
-  void SetProjectile() {}
-  void SetTarget(corsika::particles::ParticleCode targetCode) {
-    event_->targetCode = targetCode;
-  }
-};