History

We need this MR to discuss details and technicalities of this branch.

The code approval procedure is described in the wiki: Code approval procedure wiki

• The MR is without WIP (work in progress) status
• Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
  • if "check clang-format" failed: the code contributor has to run ./do-clang-format.py --apply eventually with the --all option
  • if "check copyright" failed the code contributor has to run./do-copyright.py --add=20xy
• Make sure also the jobs with label ready for code review succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur
• Check in the "coverage" job output that the coverage did not decreases. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
• On the MR page, open the "Open in Web IDE" tool
  • Check if the provided solution solves the Issue, discuss on gitlab
  • Check that all changes are actually related to the issue
  • There are no debug statements left, not even commented out
  • Check all changes for coding rules and guidelines
• When all above is done:
  • Add MR label "Code Review Finished"

Documentation/Examples/CMakeLists.txt

@@ -9,12 +9,12 @@ CORSIKA_ADD_EXAMPLE (geometry_example)
 target_link_libraries (geometry_example CORSIKAgeometry CORSIKAunits)
 
 CORSIKA_ADD_EXAMPLE (stack_example)
-target_link_libraries (stack_example SuperStupidStack CORSIKAunits)
+target_link_libraries (stack_example CORSIKAsetup CORSIKAunits)
 
 # address sanitizer is making this example too slow, so we only do "undefined"
 CORSIKA_ADD_EXAMPLE (boundary_example)
 target_link_libraries (boundary_example
-  SuperStupidStack
+  CORSIKAsetup
   CORSIKAunits
   CORSIKAlogging
   CORSIKArandom
@@ -34,7 +34,7 @@ target_link_libraries (boundary_example
 
 CORSIKA_ADD_EXAMPLE (cascade_example)
 target_link_libraries (cascade_example
-  SuperStupidStack
+  CORSIKAsetup
   CORSIKAunits
   CORSIKAlogging
   CORSIKArandom
@@ -59,7 +59,7 @@ target_link_libraries (cascade_example
 if (Pythia8_FOUND)
   CORSIKA_ADD_EXAMPLE (cascade_proton_example)
   target_link_libraries (cascade_proton_example
-    SuperStupidStack
+    CORSIKAsetup
     CORSIKAunits
     CORSIKAlogging
     CORSIKArandom
@@ -87,10 +87,15 @@ if (Pythia8_FOUND)
 
   CORSIKA_ADD_EXAMPLE (vertical_EAS RUN_OPTIONS 4 2 10000.)
   target_link_libraries (vertical_EAS
-    SuperStupidStack
+    CORSIKAsetup
     CORSIKAunits
     CORSIKAlogging
     CORSIKArandom
+    CORSIKAhistory
+    ProcessSibyll
+    ProcessPythia8
+    ProcessUrQMD
+    ProcessSwitch
     CORSIKAcascade
     ProcessProposal
     ProcessPythia8
@@ -110,12 +115,13 @@ if (Pythia8_FOUND)
     CORSIKAgeometry
     CORSIKAenvironment
     CORSIKAprocesssequence
+    CORSIKAhistory # for HistoryObservationPlane
     )
 endif()
 
 CORSIKA_ADD_EXAMPLE (stopping_power stopping_power)
 target_link_libraries (stopping_power
-  SuperStupidStack
+  CORSIKAsetup
   CORSIKAunits
   ProcessEnergyLoss
   CORSIKAparticles