History

We need this MR to discuss details and technicalities of this branch.

The code approval procedure is described in the wiki: Code approval procedure wiki

• The MR is without WIP (work in progress) status
• Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
  • if "check clang-format" failed: the code contributor has to run ./do-clang-format.py --apply eventually with the --all option
  • if "check copyright" failed the code contributor has to run./do-copyright.py --add=20xy
• Make sure also the jobs with label ready for code review succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur
• Check in the "coverage" job output that the coverage did not decreases. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
• On the MR page, open the "Open in Web IDE" tool
  • Check if the provided solution solves the Issue, discuss on gitlab
  • Check that all changes are actually related to the issue
  • There are no debug statements left, not even commented out
  • Check all changes for coding rules and guidelines
• When all above is done:
  • Add MR label "Code Review Finished"

changed milestone to %History Version

added Comments Requested Development Stack labels

added 1 commit

• ce330b9a - renamed HSecondaryView to HistorySecondaryView

Compare with previous version

added 1 commit

• a0b8084d - SetupStack is now using HistoryStackExtension

Compare with previous version

added 4 commits

• 401a0e9d - started HistoryObservationPlane
• d8cc6ee3 - documentation improved
• 4ff19fa5 - event structure
• e2fe2a26 - adapted testHistoryView to new semantics

Compare with previous version

added 3 commits

• 931d631c - deleted prototype file
• dd4079cb - simple HistoryObservationPlane
• c9718741 - first try real-world history with vertical_EAS

Compare with previous version

added 3 commits

• 75bf7157 - use SecondaryView instad of SeoncdaryView::GetProjectile() as argument
• 0557a5a7 - use SecondaryView in DoInteraction() instead of projectile
• 76634c6f - first time working w/o crash

Compare with previous version

added 1 commit

• 2d3fc97d - first time working w/o crash

Compare with previous version

added 33 commits

• 75bf7157 - use SecondaryView instad of SeoncdaryView::GetProjectile() as argument
• 0557a5a7 - use SecondaryView in DoInteraction() instead of projectile
• ba9eb0ac - adapt testCascade
• 4ccf13bb - added parent() function to get original parent particle back
• 27b59a63 - prjectile -> view
• 3eca9dd3 - style
• 88783fb3 - clang setup-view
• 7dc8fa27 - adapted tests to DoInteraction(SecondaryView)
• ca7b77f9 - Merge branch '303-type-of-projectile-in-stackview' into addsecondary_interface
• c3c88225 - use SecondaryView instad of SeoncdaryView::GetProjectile() as argument
• 7a6af436 - use SecondaryView in DoInteraction() instead of projectile
• ca7a1f60 - adapt testCascade
• b9e3e14d - added parent() function to get original parent particle back
• 79361796 - prjectile -> view
• 00dd4c5b - style
• 4037593c - clang setup-view
• 25580181 - adapted tests to DoInteraction(SecondaryView)
• 0c1b0e46 - modified tests to use setup::StackView together with setup::Stack
• 77a48b3f - fixed clang problem by moving static_pow out of detail.
• ec50f94a - fixed clang problem by moving static_pow out of detail.
• 8c0311eb - towards transparent HistorySecondaryView
• 20299396 - slight cleanup of SetupStack
• d08bdb71 - changed HistorySecondaryView to HistorySecondaryProducer. Now also secondaries...
• 4a4ede9a - clang-specific naming clarifications
• 44ff8cb1 - added copy and swap particle test cases
• 2d157bb6 - HadronicElasticModel produces secondary
• 52832796 - fix template default parameter for secondaryview
• 79b7d386 - Merge branch 'addsecondary_interface' of...
• c6a05678 - revert column-width for clang-foramt back to 90
• 7fcabc99 - fixed clang history option
• 3354a4df - fixed typo
• 0cdfdbfa - added proper stack-handling to NuclearInteraction process
• 8b86a77c - Merge branch 'addsecondary_interface' into 'history'

Compare with previous version

Note: after the docker container update the (old) qgsjetII test is failing. this was fixed on the "add histogramming" branch and when merged into master: a rebase to master should fix this.

@rprechelt Max and me were working on this "History" branch. It is very complex and has a ton of changes. It may be too much for a detailed review, and it is one of those monster-MR that in principle we want to avoid...

Could you still have at least a brief look at this? Max will likely set the "ready for code review" tag very soon.

added 1 commit

• 4466e10a - moved new_view() into constructors of mix-in classes

Compare with previous version

added 2 commits

• 04693557 - consistent source/include paths
• 467ec625 - SecondaryParticle as struct

Compare with previous version

Max, the failing QGSJetII unit test in clang is purely because of the underlying container update #307

If you do a rebase to master this will go away.

added 2 commits

• 3f7f62fa - count generations in testHistoryView
• 88bf53a3 - add event type flag, set in Cascade

Compare with previous version

added 27 commits

• 88bf53a3...05da753b - 26 commits from branch master
• 3fa3c64e - Merge branch 'master' into history

Compare with previous version

added 4 commits

• 68d3bae2 - standard observation level in vertical_EAS
• e7813401 - fixed some remaining issues after merge
• 3cd855db - compile-time detection of history
• 88b7b993 - fixed setting of event type

Compare with previous version

added 1 commit

• ac817a7d - fixed ParticleCut

Compare with previous version

added 1 commit

• bec743fd - count only interactions in HistoryObservationPlane

Compare with previous version

unmarked as a Work In Progress