IAP GITLAB

Skip to content
Snippets Groups Projects

Resolve "ParticleCut for tau leptons"

Merged Felix Riehn requested to merge 621-particlecut-for-tau-leptons into master

Closes #621 (closed)

The code approval procedure is described in the wiki: Code approval procedure wiki

  • The MR is without WIP/Draft status
  • Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
    • if "check clang-format" failed: the code contributor has to run ./do-clang-format.py --apply eventually with the --all option
    • if "check copyright" failed the code contributor has to run./do-copyright.py --add=20xy
  • Make sure also the jobs with MR-label ready for code review succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-14", "release-u-22.04" and make sure no problems occur. You may have to trigger a pipeline manually to check this.
  • Check in the "coverage" job output that the coverage did not decrease. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
  • On the MR page, open the "Open in Web IDE" tool
    • Check if the provided solution solves the Issue, discuss on gitlab
    • Check that all changes are actually related to the issue
    • There are no debug statements left, not even commented out
    • Check all changes for coding rules and guidelines
  • When all above is done:
    • Add MR label "Code Review Finished"
    • Approve (click button)
    • Rebase, if needed. If unclear: discuss!
      • git rebase master (rebase on top of master)
      • git merge master (merge back changes from master)
Edited by Felix Riehn

Merge request reports

Merge request pipeline #13929 passed

Merge request pipeline passed for b94f33b1

Test coverage 95.40% (23.20%) from 1 job

Merged by Marvin GottowikMarvin Gottowik 3 months ago (Sep 19, 2024 1:31pm UTC)

Loading

Pipeline #13940 passed

Pipeline passed for 6a0185b6 on master

Test coverage 72.20% (23.20%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading