Resolve "Downgrade warning for particles beyond shower axis"

Closes #668 (closed)

changed milestone to %Beta Release

added Output label

requested review from @JAlameddine

assigned to @acoleman

added 1 commit

• c36db7cf - downgrade shower axis warns to debug

Compare with previous version

marked this merge request as ready

This could maybe even go lower to TRACE instead of DEBUG?

added Ready for Code Review label

If I understand correctly, this message is thrown in case the projection of the particle onto the shower axis is beyond or before the defined axis.

It would be a good idea to document the behavior (i.e., returning MinimumX or MaximumX). I can add a few sentences to the documentation of this code to make this clear.

added 1 commit

• fd59f8ba - Add documentation of ShowerAxis.hpp

Compare with previous version

added 1 commit

• 57dcb7d0 - downgrade to TRACE

Compare with previous version

added 5 commits

• 57dcb7d0...d748500c - 2 commits from branch master
• 3b9a4562 - downgrade shower axis warns to debug
• 0e4f91af - Add documentation of ShowerAxis.hpp
• d12f3293 - downgrade to TRACE

Compare with previous version

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for d12f3293 succeeds

merged

mentioned in commit 5b7650ab