Conex EM
-
Review changes -
-
Download -
Patches
-
Plain diff
Closes #191 (closed)
The code approval procedure is described in the code approval procedure wiki
-
The MR is without WIP (work in progress) status -
Make sure the most recent CI jobs (config, quality, build, tests) all run fine with no failures - if "check clang-format" failed: the code contributor has to run
./do-clang-format.py --apply
eventually with the--all
option - if "check copyright" failed the code contributor has to run
./do-copyright.py --add=20xy
- if "check clang-format" failed: the code contributor has to run
-
Also run all the extra optional jobs "coverage", "release-clang-8", "release-u-18.04" and make sure no problems occur -
Check in the "coverage" job output that the coverage did not decreases (!). It should always stay, or increase. If it decreased --> ask contributor to add further unit tests, and check coverage report. - On the MR page, open the "Open in Web IDE" tool
-
Check if the provided solution solves the Issue, discuss on gitlab -
Check that all changes are actually related to the issue -
There are no debug statements left, not even commented out -
Check all changes for coding rules and guidelines
-
- When all above is done
-
Add label "Code Review Finished"
-
Edited by Ralf Ulrich
Merge request reports
Compare and
- version 239216c9b3
- version 22d9b3ea97
- version 21ce6af9a0
- version 206561dcec
- version 199c34371b
- version 18a748ea4e
- version 171d096877
- version 165ef91758
- version 15678c013f
- version 14deb2cca6
- version 13cf24571d
- version 12f0fb0e4d
- version 11d8559397
- version 101e34ea59
- version 9ae4945d9
- version 8493f3a91
- version 7dcf84c49
- version 69225599c
- version 55da54e05
- version 4fdd77141
- version 3318e3d1d
- version 2a6345cab
- version 1eff36503
- master (base)
- latest versionccb14a0065 commits,
- version 239216c9b364 commits,
- version 22d9b3ea9766 commits,
- version 21ce6af9a065 commits,
- version 206561dcec64 commits,
- version 199c34371b61 commits,
- version 18a748ea4e60 commits,
- version 171d09687759 commits,
- version 165ef9175858 commits,
- version 15678c013f57 commits,
- version 14deb2cca656 commits,
- version 13cf24571d55 commits,
- version 12f0fb0e4d54 commits,
- version 11d855939752 commits,
- version 101e34ea5951 commits,
- version 9ae4945d950 commits,
- version 8493f3a9149 commits,
- version 7dcf84c4947 commits,
- version 69225599c45 commits,
- version 55da54e0544 commits,
- version 4fdd7714143 commits,
- version 3318e3d1d42 commits,
- version 2a6345cab41 commits,
- version 1eff3650340 commits,
Compare changes
- Side-by-side
- Inline
Files
33Loading