Coding style guide needed

The wiki refers to (non existing) coding guidelines. As we are adding contributors to the project, this will become more important.

This thought got triggered when I was looking into the ordering of #include directives. I found different orders in the code.

In my experience, the order

1. Project (corsika) headers
2. Other
   1. Third party
   2. boost
   3. STL

is a reasonable order. By having the project headers first, you are more likely to get a compile time error if a header is missing an include.

For the discussion, we should try to get feedback from @darko as auger's chief style cosmetologist. He spent some time on the attached auger offline style guide.

We have some guidelines already: https://gitlab.ikp.kit.edu/AirShowerPhysics/corsika/blob/master/CONTRIBUTING.md

OK, the bug was in the wiki, it pointed to .../blob/master/GUIDELINES.md. Fixed.

closed

mentioned in issue #157 (closed)

Yes, this guide is not complete. It is still Darko's job (since the beginning) to look at this. I will ask him to do this during the next time.

Besides that, we rely on .clang-format for all "cosmetix" and "indenting". In corsika8 there is 0 flexibility on style on this level (see #160 (closed) ), we only have to refine our .clang-format file.

IncludeBlocks IBS_Regroup and combined it with IncludeCategories ...

Besides clang-format we mostly need to rely on naming and conventions.

assigned to @darko

changed milestone to %ICRC2019