typo

Makefile

@@ -95,8 +95,8 @@ endif
 
 LDFLAGS += -lbz2
 SOFLAGS += -lbz2
-ifneq ("$(BZIP2_INCLUD_DIR)", "")
- CXXFLAGS += -I${BZIP2_INCLUD_DIR}
+ifneq ("$(BZIP2_INCLUDE_DIR)", "")
+ CXXFLAGS += -I${BZIP2_INCLUDE_DIR}
 endif ()
 CXXFLAGS += -std=c++17 -I$(TABDIR)/readLib/externals/compress_stream/include
 

[Remy Prechelt]

Thank you for catching this - this was annoying me this evening!

[Ralf Ulrich]

Also thank you from me! If we had time, we should write a proper cmake build file for cxroot. The old archaic Makefile is going to make more problems.

[Remy Prechelt]

I think the main cause of this was ThirdParty/CMakeLists.txt. It always downloads the latest master branch of this repo. This breaks reproducibility of our git history since there is no easy way to get the version of cxroot that was in use at the time a commit was made i.e. this issue was causing my old branches that were working to fail.

Ideally, once we are further along in development, we should think about explicitly versioning all of our dependencies (for cxroot, that would be with git tags).

[Ralf Ulrich]

Yes, you are right. This is not a good idea.