... | ... | @@ -14,6 +14,22 @@ If we are in a position where new developments or bug fixes need to be merged fr |
|
|
- If useful discuss ongoing MR review in CORSIKA meeting
|
|
|
- Approve on gitlab
|
|
|
|
|
|
```mermaid
|
|
|
graph TD;
|
|
|
subgraph "Code contributor"
|
|
|
A0[Working on MR/branch] -- Finished main work --> A1[Remove WIP status];
|
|
|
A1 --> A2[Make sure all conditions for code review and approval are met];
|
|
|
A2 -- Ok --> A3[Add MR tag 'ready for code review'];
|
|
|
end
|
|
|
subgraph "Code reviewer"
|
|
|
A3 --> B0[A suited developer is picked for code review];
|
|
|
B0 --> B1[Reviewer copies task list from below into MR];
|
|
|
B1 --> B2[Reviewer checks each item on task list];
|
|
|
B2 --> B3[Final check means APPROVED for merging];
|
|
|
end
|
|
|
```
|
|
|
|
|
|
|
|
|
Concrete rule: Make a copy of the below section in the MR discussion section and go through all the points:
|
|
|
```
|
|
|
- [] Only Merge Requests (MR) with the Tag "ready for code review", and without WIP status are reviewed
|
... | ... | |