IAP GITLAB

Skip to content

Resolve "Fix time projection of StackInspector"

Alan Coleman requested to merge 593-fix-time-projection-of-stackinspector into master

Issues: Closes #593 (closed)

This fixes two of the three issues highlighted by @mreininghaus in #593 (closed), that the ETA actually works and that a correction is applied to ignore overhead time (such as building the proposal tables).

The first an issue in the way that std::put_time is overloaded but could be resolved by forcing a type.

The second issue was resolved by re-referencing the "start time" of the simulation to when 2% of the energy was lost. This could probably be set to a lower value, but this will certainly be safe and seemed to at least cover when all the tables are made.

This does NOT fix the issue of forcing the log-level for printing and silencing INFO will still silence the stack inspector. But this might be a larger issue and can be fixed in the future with #565.

  • The MR is without WIP/Draft status
  • Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
    • if "check clang-format" failed: the code contributor has to run ./do-clang-format.py --apply eventually with the --all option
    • if "check copyright" failed the code contributor has to run./do-copyright.py --add=20xy
  • Make sure also the jobs with MR-label ready for code review succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur. You may have to trigger a pipeline manually to check this.
  • Check in the "coverage" job output that the coverage did not decrease. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
  • On the MR page, open the "Open in Web IDE" tool
    • Check if the provided solution solves the Issue, discuss on gitlab
    • Check that all changes are actually related to the issue
    • There are no debug statements left, not even commented out
    • Check all changes for coding rules and guidelines
  • When all above is done:
    • Add MR label "Code Review Finished"
Edited by Felix Riehn

Merge request reports

Loading