update arrow version to 8.0.1
All threads resolved!
All threads resolved!
avoid clashing definitions of mpark::variant
when including xtensor/xtl.
Arrow got rid of mpark::variant
in more recent versions, so updating solves the problem
The code approval procedure is described in the wiki: Code approval procedure wiki
-
The MR is without WIP/Draft
status -
Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures - if "check clang-format" failed: the code contributor has to run
./do-clang-format.py --apply
eventually with the--all
option - if "check copyright" failed the code contributor has to run
./do-copyright.py --add=20xy
- if "check clang-format" failed: the code contributor has to run
-
Make sure also the jobs with MR-label ready for code review
succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur. You may have to trigger a pipeline manually to check this. -
Check in the "coverage" job output that the coverage did not decrease. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report. - On the MR page, open the "Open in Web IDE" tool
-
Check if the provided solution solves the Issue, discuss on gitlab -
Check that all changes are actually related to the issue -
There are no debug statements left, not even commented out -
Check all changes for coding rules and guidelines
-
- When all above is done:
- Add MR label "Code Review Finished"
Edited by Nikos Karastathis
Merge request reports
Activity
added Build System label
requested review from @Nikos
added Ready for Code Review label
added 7 commits
-
96a9ea7b...dd5dd37e - 6 commits from branch
master
- 7bcdc0d3 - update arrow version to 8.0.1
-
96a9ea7b...dd5dd37e - 6 commits from branch
added 3 commits
-
7bcdc0d3...de2f729e - 2 commits from branch
master
- 917f5334 - update arrow version to 8.0.1
-
7bcdc0d3...de2f729e - 2 commits from branch
- Resolved by Maximilian Reininghaus
Ok, I tested extensively and I have some comments before we merge:
- I was able to build this locally with gcc 11.3 and not 9. Not quite sure if this is the only reason this happened on my laptop.
- This upgrade does solve a radio issue I had about a year ago. In the original implementation of antennas I used xtensor but there was a name clash with some arrow package and I had to let xtensor go. I re-tested this today and did not have the same issue. Although, I have to mention that if at some point we do want to use xtensor again we need to add the option
xtensor:xsimd=False
in theconanfile.txt
.
In short, if there are no strong opinions against it, I think we can safely merge.
added Code Review Finished label
removed Ready for Code Review label
added 10 commits
-
917f5334...504f8cbf - 9 commits from branch
master
- e19d8505 - update arrow version to 8.0.1
-
917f5334...504f8cbf - 9 commits from branch
mentioned in commit 289be8ac
Please register or sign in to reply