Add tracking of particle times to observation plane writer
Merge request reports
Activity
assigned to @rprechelt
added Output label
@JAlameddine Ping me when this is ready & rebased and I'll review and merge it! Some tests are failing on the CI...
Edited by Remy Precheltadded 1 commit
- 6b3abc54 - Adapt NoOutput and testOutputManager to include time
added 27 commits
-
6b3abc54...b1288e92 - 24 commits from branch
master
- 424649b9 - Add tracking of particle times to observation plane writer
- 73f8c46a - adapt testWriterObservationPlane.cpp
- 1bfd1830 - Adapt NoOutput and testOutputManager to include time
Toggle commit list-
6b3abc54...b1288e92 - 24 commits from branch
added Ready for Code Review label
@rprechelt The CI is working now, the PR is rebased and ready for review
added Code Review Finished label and removed Ready for Code Review label
The code approval procedure is described in the wiki: Code approval procedure wiki
-
The MR is without
WIP/Draft
status -
Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
- if "check clang-format" failed: the code contributor has to run
./do-clang-format.py --apply
eventually with the--all
option - if "check copyright" failed the code contributor has to run
./do-copyright.py --add=20xy
- if "check clang-format" failed: the code contributor has to run
-
Make sure also the jobs with MR-label
ready for code review
succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur. You may have to trigger a pipeline manually to check this. - Check in the "coverage" job output that the coverage did not decrease. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
- On the MR page, open the "Open in Web IDE" tool
- Check if the provided solution solves the Issue, discuss on gitlab
- Check that all changes are actually related to the issue
- There are no debug statements left, not even commented out
- Check all changes for coding rules and guidelines
- When all above is done:
- Add MR label "Code Review Finished"
- Approve (click button)
- Rebase, if needed. If unclear: discuss!
- git rebase master (rebase on top of master)
- git merge master (merge back changes from master)
Edited by Remy Prechelt-
The MR is without
added 6 commits
-
1bfd1830...5189e66d - 3 commits from branch
master
- aa823acc - Add tracking of particle times to observation plane writer
- 9ec308c1 - adapt testWriterObservationPlane.cpp
- 979d3805 - Adapt NoOutput and testOutputManager to include time
Toggle commit list-
1bfd1830...5189e66d - 3 commits from branch
added 5 commits
-
979d3805...3a97b125 - 2 commits from branch
master
- fcde6009 - Add tracking of particle times to observation plane writer
- 1d67085d - adapt testWriterObservationPlane.cpp
- 5d4c37fa - Adapt NoOutput and testOutputManager to include time
Toggle commit list-
979d3805...3a97b125 - 2 commits from branch
added 6 commits
-
5d4c37fa...99aeece5 - 3 commits from branch
master
- 3d592fd1 - Add tracking of particle times to observation plane writer
- 573d9a90 - adapt testWriterObservationPlane.cpp
- a2039030 - Adapt NoOutput and testOutputManager to include time
Toggle commit list-
5d4c37fa...99aeece5 - 3 commits from branch
mentioned in commit 8832bdda
Thanks @JAlameddine
mentioned in merge request !431 (merged)
Please register or sign in to reply