IAP GITLAB

Skip to content
Snippets Groups Projects

Partial MR to consider some changes of !158

Merged Ralf Ulrich requested to merge partial_MR158 into master

Hans proposed a series of improvements in !158 (closed) which may have been lost due to not-merging. Here is a partial MR to consider most of his ideas. The remaining good idea is to change ProcessSequence to directly use std::tuple.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ralf Ulrich changed milestone to %ICRC-2021

    changed milestone to %ICRC-2021

  • The code approval procedure is described in the wiki: Code approval procedure wiki

    • The MR is without WIP/Draft status
    • Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
      • if "check clang-format" failed: the code contributor has to run ./do-clang-format.py --apply eventually with the --all option
      • if "check copyright" failed the code contributor has to run./do-copyright.py --add=20xy
    • Make sure also the jobs with MR-label ready for code review succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur. You may have to trigger a pipeline manually to check this.
    • Check in the "coverage" job output that the coverage did not decrease. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
    • On the MR page, open the "Open in Web IDE" tool
      • Check if the provided solution solves the Issue, discuss on gitlab
      • Check that all changes are actually related to the issue
      • There are no debug statements left, not even commented out
      • Check all changes for coding rules and guidelines
    • When all above is done:
      • Add MR label "Code Review Finished"
      • Rebase, if needed. If unclear: discuss!
        • rebased
        • not rebased
    Edited by Ralf Ulrich
  • Ralf Ulrich enabled an automatic merge when the pipeline for 7d62a723 succeeds

    enabled an automatic merge when the pipeline for 7d62a723 succeeds

  • merged

  • Ralf Ulrich mentioned in commit 90a5dcce

    mentioned in commit 90a5dcce

Please register or sign in to reply
Loading