Resolve "handling of off-shell particles"
Closes #270 (closed)
Merge request reports
Activity
added Development Feature request labels
added 7 commits
- d0b193d2 - shift energies of particles from sibyll so that mass is consistent,...
- 08e9579d - shift particle masses in sibyll interface
- 20bf7cd5 - added process to check particle masses and shift on-shell if necessary
- aec9a1c7 - output format etc
- b9127282 - fixed test
- eed49b52 - set tolerance in vertical eas
- be4c20a9 - removed check from sibyll interface
Toggle commit listassigned to @riehn
added 113 commits
-
067fe091...f1e64c40 - 97 commits from branch
master - 0af4a0df - shift energies of particles from sibyll so that mass is consistent,...
- d12b7c37 - shift particle masses in sibyll interface
- 61df23dc - added process to check particle masses and shift on-shell if necessary
- 8a8051b2 - output format etc
- 6830f3fe - fixed test
- 85903759 - set tolerance in vertical eas
- 392d158e - removed check from sibyll interface
- 31742a07 - clang
- e31665dd - removed obsolete file
- c39c7315 - avoid test for nuclei
- 5fa15a5d - clang
- 288a94a0 - there you go
- cd6fbba2 - added summary
- 10344490 - added error for extreme cases
- 98d79664 - Merge branch '270-handling-of-off-shell-particles' of...
- 3e846b3d - fixed merge
Toggle commit list-
067fe091...f1e64c40 - 97 commits from branch
added Ready for Code Review label
The code approval procedure is described in the wiki: Code approval procedure wiki
-
The MR is without
WIP(work in progress) status -
Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
- if "check clang-format" failed: the code contributor has to run
./do-clang-format.py --applyeventually with the--alloption - if "check copyright" failed the code contributor has to run
./do-copyright.py --add=20xy
- if "check clang-format" failed: the code contributor has to run
-
Make sure also the jobs with label
ready for code reviewsucceed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur - Check in the "coverage" job output that the coverage did not decreases. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
- On the MR page, open the "Open in Web IDE" tool
- Check if the provided solution solves the Issue, discuss on gitlab
- Check that all changes are actually related to the issue
- There are no debug statements left, not even commented out
- Check all changes for coding rules and guidelines
- When all above is done
- Add label "Code Review Finished"
Edited by Ralf Ulrich-
The MR is without
- Resolved by Ralf Ulrich
Hello @riehn
here are a few questions:
-
why is the code limited to hadrons/nuclei? I understand this is the primary use-case, but should this not be handled in a more flexible way, or even left open? I can see why we don't care for photons, electrons, muons, etc. ... I am wondering what is your opinion.
-
please replace all "REQUIRE"s by "CHECK"s in the testOnShellCheck. The advantage is that CHECK will run all the other CHECKs, too, while REQUIRE will stop at the first failure.
-
in pythia/Decay.cc, what is the signficance of changing:
- fPythia.readString("Check:particleData = 0");
- fPythia.readString("Check:event = 1");
What is the impact of the new module? Does it produce less failures/warning? Is it more robust now? Does the shower of vertical_eas change in a [meaningful] way?
Edited by Ralf Ulrich -
- Last reply by Ralf Ulrich
