Copyright
Closes #160 (closed)
Merge request reports
Activity
added Development Ready for Code Review labels
There are lots of unrelated things here. Besides that:
- If you use docstrings instead of normal comments to document the functions they are parseable by Python and usable in the
help()function. - Can we get rid of the newline before the actual header starts? It's a matter of taste, of course, but at least I always found this a bit ugly.
- If you use docstrings instead of normal comments to document the functions they are parseable by Python and usable in the
Instead of
############################################### # # check files: loops over list of files, # excludes if wished, process otherwise # def next_file(dir_name, files):write
def next_file(dir_name, files): """check files: loops over list of files, excludes if wished, process otherwise. """See https://www.python.org/dev/peps/pep-0257/. It's like doxygen for Python.
Edited by Maximilian ReininghausRegarding the newline, I think I didn't explain properly. For example, instead of
/* * (c) Copyright 2018 CORSIKA Project, corsika-project@lists.kit.edu * [...] */ #ifndef _include_RNGManager_h_ #define _include_RNGManager_h_I'd prefer
/* * (c) Copyright 2018 CORSIKA Project, corsika-project@lists.kit.edu * [...] */ #ifndef _include_RNGManager_h_ #define _include_RNGManager_h_Notice the empty line right at the beginning of the file. I guess you were referring to the one between the copyright and the include guard which I like as well.
added 14 commits
- b5f72379 - removed wrong copyright
- dd521f72 - use regex for do-copyright
- f5649f07 - added/updated copyright notice
- aa52539e - fixed script
- 2fe91ac1 - include copyright check in unit tests
- 90b11570 - removed empty files
- 23dc3dd8 - removed empty line
- becf084a - removed empty lines
- fbdb239d - also run clang-format checking automatically as unit test
- 3bedd301 - remove quotation
- ebe51245 - python3
- 37fa0444 - more verbose ctest
- 49114d5c - consider utf8
- b5986915 - again, reduce verbosity level for CI a bit
Toggle commit list
To the newline --> I see now. I did not notice this superfluous line. I will check.
To the commit history --> there were unrelated commits at the beginning of the branch. I think I initially did not branch from master but from another devel branch. I deleted those commit, making the branch clean in scope. THE HISTORY HAS CHANGED. BE CAREFUL WITH LOCAL CHECKOUTS of the copyright branch!
