Make check of equivalence of logical vs. numerical nodes optional
The node lookup/check (Cascade.inl
after // final sanity check, no actions
) likely affects performance to some extent.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
- Show closed items
Link issues together to show that they're related.
Learn more.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Maximilian Reininghaus added Easy First Issue Performance labels
added Easy First Issue Performance labels
- Tim Huege changed milestone to %2023 Workshop Milestone
changed milestone to %2023 Workshop Milestone
- Alan Coleman changed milestone to %Beta Release
changed milestone to %Beta Release
- Marvin Gottowik assigned to @alice.faure
assigned to @alice.faure
- Marvin Gottowik removed milestone %Beta Release
removed milestone %Beta Release
- Maintainer
just for documentation:
./c8_air_shower -p 2212 --filename test --energy 1e3 --force-interaction -z 88 -s 1832495174 ... [corsika:error (Cascade.inl:307)] expect to be in node currentLogicalNode=0x563955b82d10 but are in numericalNodeAfterStep=0x563955b82b40. Continue, but without guarantee. [corsika:error (Intersect.inl:110)] There is a very negative time step detected: -1.16022e-07 s. This is not physical and may easily crash subsequent modules. Set to 0_s, but CHECK AND FIX.
shower finishes and output is there. We decided to move outputs to debug
Edited by Marvin Gottowik 1 - Marvin Gottowik mentioned in merge request !650 (merged)
mentioned in merge request !650 (merged)
- Alice Faure created branch
589-make-check-of-equivalence-of-logical-vs-numerical-nodes-optional
to address this issuecreated branch
589-make-check-of-equivalence-of-logical-vs-numerical-nodes-optional
to address this issue - Alice Faure mentioned in merge request !652 (merged)
mentioned in merge request !652 (merged)
- Alan Coleman mentioned in commit a1250860
mentioned in commit a1250860
- Alan Coleman closed with merge request !652 (merged)
closed with merge request !652 (merged)
Please register or sign in to reply