AddSecondary() does not copy "constant" data from projectile
If projectile.AddSecondary(...) is called, the "constant" data (4-position, node, whatever other information is stored on the stack) should be copied. It cannot be the responsibility of the process to do this. For instance Sibyll/Decay should not need to take care of the decay point.
Activity
That is basically the whole idea behind the CombinedStack and AddSecondary mechanism. The testCombined test also check that. Does it fail? But for the particular case you report here, we should have a clear test-case on a branch so we can look at the details. Can I checkout !76 (merged) does it clearly expose this bug in cascade_example? Or in testCascade?
cascade_example in !76 (merged) fails with my latest commit.
-
Very good.
I close this Issue, since I believe it is integral part of #82 (closed). This must be something very specific about the VolumeNodes, maybe the Nodes disappear since they are unique_ptrs?
OK, but then Sibyll/Decay and Interaction need to be modified because they do the copying of the 4-position. Let's continue the discussion about the nodes in !76 (merged).
-
Just to clarify: this was fixed with commit 9bcb3367 by calling the Particle::Delete of the parent particle after the calls to AddSecondary(...) in sibyll. Now it works as it should: the data is copied automatically to secondaries on the stack.
