IAP GITLAB

Skip to content
Snippets Groups Projects
Commit acaecd0a authored by ralfulrich's avatar ralfulrich
Browse files

removed FIXMEs

parent 17e89cf2
No related branches found
No related tags found
1 merge request!280Refactory 2020
...@@ -156,7 +156,7 @@ namespace corsika { ...@@ -156,7 +156,7 @@ namespace corsika {
} else if constexpr (std::is_base_of_v<InteractionProcess<process1_type>, } else if constexpr (std::is_base_of_v<InteractionProcess<process1_type>,
process1_type>) { process1_type>) {
// if this is not a ContinuousProcess --> evaluate probability // if this is not a ContinuousProcess --> evaluate probability
// FIXME lambda_inv_sum += A_.getInverseInteractionLength(view.parent()); lambda_inv_sum += A_.getInverseInteractionLength(view.parent());
// check if we should execute THIS process and then EXIT // check if we should execute THIS process and then EXIT
if (lambda_inv_select < lambda_inv_sum) { if (lambda_inv_select < lambda_inv_sum) {
A_.doInteraction(view); A_.doInteraction(view);
...@@ -170,7 +170,8 @@ namespace corsika { ...@@ -170,7 +170,8 @@ namespace corsika {
} else if constexpr (std::is_base_of_v<InteractionProcess<process2_type>, } else if constexpr (std::is_base_of_v<InteractionProcess<process2_type>,
process2_type>) { process2_type>) {
// if this is not a ContinuousProcess --> evaluate probability // if this is not a ContinuousProcess --> evaluate probability
//lambda_inv_sum += B_.getInverseInteractionLength(view.parent()); <-- FIXME as soon as SecondaryView::parent() is migrated! lambda_inv_sum += B_.getInverseInteractionLength(view.parent());
// soon as SecondaryView::parent() is migrated!
// check if we should execute THIS process and then EXIT // check if we should execute THIS process and then EXIT
if (lambda_inv_select < lambda_inv_sum) { if (lambda_inv_select < lambda_inv_sum) {
B_.doInteraction(view); B_.doInteraction(view);
...@@ -214,7 +215,7 @@ namespace corsika { ...@@ -214,7 +215,7 @@ namespace corsika {
if (ret != ProcessReturn::Ok) { return ret; } if (ret != ProcessReturn::Ok) { return ret; }
} else if constexpr (std::is_base_of_v<DecayProcess<process1_type>, process1_type>) { } else if constexpr (std::is_base_of_v<DecayProcess<process1_type>, process1_type>) {
// if this is not a ContinuousProcess --> evaluate probability // if this is not a ContinuousProcess --> evaluate probability
// FIXME decay_inv_sum += A_.getInverseLifetime(view.parent()); decay_inv_sum += A_.getInverseLifetime(view.parent());
// check if we should execute THIS process and then EXIT // check if we should execute THIS process and then EXIT
if (decay_inv_select < decay_inv_sum) { // more pedagogical: rndm_select < if (decay_inv_select < decay_inv_sum) { // more pedagogical: rndm_select <
// decay_inv_sum / decay_inv_tot // decay_inv_sum / decay_inv_tot
...@@ -228,7 +229,7 @@ namespace corsika { ...@@ -228,7 +229,7 @@ namespace corsika {
return B_.selectDecay(view, decay_inv_select, decay_inv_sum); return B_.selectDecay(view, decay_inv_select, decay_inv_sum);
} else if constexpr (std::is_base_of_v<DecayProcess<process2_type>, process2_type>) { } else if constexpr (std::is_base_of_v<DecayProcess<process2_type>, process2_type>) {
// if this is not a ContinuousProcess --> evaluate probability // if this is not a ContinuousProcess --> evaluate probability
// FIXME decay_inv_sum += B_.getInverseLifetime(view.parent()); decay_inv_sum += B_.getInverseLifetime(view.parent());
// check if we should execute THIS process and then EXIT // check if we should execute THIS process and then EXIT
if (decay_inv_select < decay_inv_sum) { if (decay_inv_select < decay_inv_sum) {
B_.doDecay(view); B_.doDecay(view);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment