comments

corsika/detail/modules/sophia/InteractionModel.inl

@@ -81,7 +81,7 @@ namespace corsika::sophia {
     double Enucleon = nucleonP4.getTimeLikeComponent() / 1_GeV;
     double Ephoton = photonP4.getTimeLikeComponent() / 1_GeV;
     double theta = 0.0; // set nucleon at rest in collision
-    int Imode;
+    int Imode = -1; // overwritten inside SOPHIA
     CORSIKA_LOGGER_DEBUG(logger_,
                          "calling SOPHIA eventgen with L0={}, E0={}, eps={},theta={}",
                          nucleonSophiaCode, Enucleon, Ephoton, theta);

corsika/modules/Sophia.hpp

@@ -14,25 +14,3 @@
 
 #include <corsika/framework/process/InteractionProcess.hpp>
 
-/**
- * @file Sophia.hpp
- *
- * Includes all the parts of the Sophia model. Defines the InteractionProcess<TModel>
- * classes needed for the ProcessSequence.
- */
-
-namespace corsika::sophia {
-  /**
-   * @brief sophia::Interaction is the process for ProcessSequence.
-   *
-   * The sophia::InteractionModel is wrapped as an InteractionProcess here in order
-   * to provide all the functions for ProcessSequence.
-   */
-  // struct Interaction : public InteractionModel, public InteractionProcess<Interaction>
-  // {
-  //   template <typename TEnvironment>
-  //   Interaction(TEnvironment const& env)
-  //       : InteractionModel{env} {}
-  // };
-
-} // namespace corsika::sophia

corsika/modules/sophia/InteractionModel.hpp

@@ -42,8 +42,8 @@ namespace corsika::sophia {
     /**
      * @brief evaluated validity of collision system.
      *
-     * SOPHIA only accepts nucleons as targets, or protons aka Hydrogen or
-     * neutrons (p,n == nucleon).
+     * SOPHIA only accepts nucleons as targets, that is protons (Hydrogen) or
+     * neutrons.
      */
     bool constexpr isValid(Code const projectileId, Code const targetId,
                            HEPEnergyType const sqrtSnn) const;

corsika/modules/sophia/ParticleConversion.hpp

@@ -20,17 +20,6 @@ namespace corsika::sophia {
   enum class SophiaCode : int8_t;
   using SophiaCodeIntType = std::underlying_type<SophiaCode>::type;
 
-  // /**
-  //    These are the possible projectile for which Sibyll knows the cross section
-  //  */
-  // enum class SibyllXSClass : int8_t {
-  //   CannotInteract = 0,
-  //   Baryon = 1,
-  //   Pion = 2,
-  //   Kaon = 3,
-  // };
-  // using SophiaXSClassIntType = std::underlying_type<SophiaXSClass>::type;
-
 #include <corsika/modules/sophia/Generated.inc>
 
   SophiaCode constexpr convertToSophia(Code const pCode) {
@@ -52,13 +41,6 @@ namespace corsika::sophia {
     return static_cast<int>(convertToSophia(code));
   }
 
-  // int constexpr getSophiaXSCode(Code const code) {
-  //   if (is_nucleus(code))
-  //     return static_cast<SophiaXSClassIntType>(SophiaXSClass::CannotInteract);
-  //   return static_cast<SophiaXSClassIntType>(
-  //       corsika2sophiaXStype[static_cast<CodeIntType>(code)]);
-  // }
-
   bool constexpr canInteract(Code const pCode) {
     return (pCode == Code::Photon ? true : false);
   }

tests/modules/testProposal.cpp

@@ -100,7 +100,6 @@ TEST_CASE("ProposalInterface", "modules") {
     // finish successfully
     CHECK(emModel.doHadronicPhotonInteraction(view, cs, P4, Code::Oxygen) ==
           ProcessReturn::Ok);
-    // no LE interactions
     CHECK(stack.getEntries() == 6);
     CORSIKA_LOG_INFO("Number of particles produced in hadronic photon interaction: {}",
                      stack.getEntries() - 1);