set nodes at beginning of cascade

Documentation/Examples/cascade_example.cc

@@ -36,9 +36,6 @@
 
 #include <corsika/utl/CorsikaFenv.h>
 
-#include <boost/type_index.hpp>
-using boost::typeindex::type_id_with_cvr;
-
 #include <iostream>
 #include <limits>
 #include <typeinfo>
@@ -267,9 +264,6 @@ int main() {
   // auto sequence = p0 << sibyll << decay << hadronicElastic << cut << trackWriter;
   auto sequence = p0 << sibyll << sibyllNuc << decay << cut << trackWriter;
 
-  // cout << "decltype(sequence)=" << type_id_with_cvr<decltype(sequence)>().pretty_name()
-  // << "\n";
-
   // setup particle stack, and add primary particle
   setup::Stack stack;
   stack.Clear();

Framework/Cascade/Cascade.h

@@ -77,12 +77,28 @@ namespace corsika::cascade {
       fProcessSequence.Init();
       fStack.Init();
     }
+    
+    /**
+     * set the nodes for all particles on the stack according to their numerical
+     * position
+     */
+    void SetNodes() {
+        std::for_each(fStack.begin(), fStack.end(), [&](auto& p) {
+            auto const* numericalNode =
+            fEnvironment.GetUniverse()->GetContainingNode(p.GetPosition());
+            p.SetNode(numericalNode);
+            
+            std::cout << "initial node " << p.GetNode() << std::endl; 
+        });
+    }
 
     /**
      * The Run function is the main simulation loop, which processes
      * particles from the Stack until the Stack is empty.
      */
     void Run() {
+      SetNodes();
+      
       while (!fStack.IsEmpty()) {
         while (!fStack.IsEmpty()) {
           auto pNext = fStack.GetNextParticle();

[Ralf Ulrich]

I guess you have seen that the "Node" information is automatically passed on to "secondaries" produced on the stack. Thus, after your initialization this information should be correct for all particles, until they traverse into a different volume.

[Maximilian Reininghaus]

I think they are not. The first secondary processed in the loop already has a null pointer.

[Ralf Ulrich]

this was resolved as part of MR !76 (merged)