worked on some compiler warnings. there are more.

Framework/Cascade/testCascade.cc

 #include <corsika/cascade/Cascade.h>
 #include <corsika/geometry/LineTrajectory.h>
 #include <corsika/process/ProcessSequence.h>
+#include <corsika/process/stack_inspector/StackInspector.h>
 #include <corsika/stack/super_stupid/SuperStupidStack.h>
 
 #define CATCH_CONFIG_MAIN // This tells Catch to provide a main() - only do this in one

Framework/Logging/BufferedSink.h

@@ -32,7 +32,7 @@ namespace corsika::logging {
       inline void Add(const std::string& s) { fBuffer << s; }
 
     private:
-      int fSize;
+      unsigned int fSize;
       std::ostringstream fBuffer;
     };
 

Framework/Logging/MessageOff.h

@@ -10,7 +10,7 @@ namespace corsika::logging {
   class MessageOff {
   protected:
     template <typename First, typename... Strings>
-    std::string Message(const First& arg, const Strings&... rest) {
+    std::string Message(const First& , const Strings&... ) {
       return "";
     }
   };

Framework/ProcessSequence/testProcessSequence.cc

@@ -16,7 +16,7 @@ public:
   Process1() {}
   void Init() {} // cout << "Process1::Init" << endl; }
   template <typename D, typename T, typename S>
-  inline EProcessReturn DoContinuous(D& d, T& t, S& s) const {
+  inline EProcessReturn DoContinuous(D& d, T& , S& ) const {
     for (int i = 0; i < 10; ++i) d.p[i] += 1 + i;
     return EProcessReturn::eOk;
   }
@@ -27,7 +27,7 @@ public:
   Process2() {}
   void Init() {} // cout << "Process2::Init" << endl; }
   template <typename D, typename T, typename S>
-  inline EProcessReturn DoContinuous(D& d, T& t, S& s) const {
+  inline EProcessReturn DoContinuous(D& d, T& , S& ) const {
     for (int i = 0; i < 10; ++i) d.p[i] *= 0.7;
     return EProcessReturn::eOk;
   }
@@ -38,7 +38,7 @@ public:
   Process3() {}
   void Init() {} // cout << "Process3::Init" << endl; }
   template <typename D, typename T, typename S>
-  inline EProcessReturn DoContinuous(D& d, T& t, S& s) const {
+  inline EProcessReturn DoContinuous(D& d, T& , S& ) const {
     for (int i = 0; i < 10; ++i) d.p[i] += 0.933;
     return EProcessReturn::eOk;
   }
@@ -49,7 +49,7 @@ public:
   Process4() {}
   void Init() {} // cout << "Process4::Init" << endl; }
   template <typename D, typename T, typename S>
-  inline EProcessReturn DoContinuous(D& d, T& t, S& s) const {
+  inline EProcessReturn DoContinuous(D& d, T& , S& ) const {
     for (int i = 0; i < 10; ++i) d.p[i] /= 1.2;
     return EProcessReturn::eOk;
   }

Framework/Random/RNGManager.cc

@@ -23,8 +23,9 @@ std::stringstream corsika::random::RNGManager::dumpState() const {
 
   return buffer;
 }
-
+/*
 void corsika::random::RNGManager::SetSeedSeq(std::string const& pStreamName,
                                              std::seed_seq const& pSeedSeq) {
   seeds[pStreamName] = pSeedSeq;
 }
+*/

Framework/Random/RNGManager.h

@@ -42,7 +42,7 @@ namespace corsika::random {
     /**
      * set seed_seq of \a pStreamName to \a pSeedSeq
      */
-    void SetSeedSeq(std::string const& pStreamName, std::seed_seq& const pSeedSeq);
+    //void SetSeedSeq(std::string const& pStreamName, std::seed_seq& const pSeedSeq);
   };
 
 } // namespace corsika::random

Framework/StackInterface/ParticleBase.h

@@ -48,6 +48,6 @@ namespace corsika::stack {
     int GetIndex() const { return GetIterator().GetIndex(); }
   };
 
-}; // namespace corsika::stack
+} // namespace corsika::stack
 
 #endif

Framework/StackInterface/StackIterator.h

@@ -56,18 +56,18 @@ namespace corsika::stack {
   public:
     // StackIterator() : fData(0), fIndex(0) { }
     StackIteratorInterface(StackType& data, const int index)
-        : fData(&data)
-        , fIndex(index) {}
+        : fIndex(index)
+        , fData(&data) {}
 
   private:
     StackIteratorInterface(const StackIteratorInterface& mit)
-        : fData(mit.fData)
-        , fIndex(mit.fIndex) {}
+        : fIndex(mit.fIndex)
+        , fData(mit.fData) {}
 
   public:
     StackIteratorInterface& operator=(const StackIteratorInterface& mit) {
-      fData = mit.fData;
       fIndex = mit.fIndex;
+      fData = mit.fData;
       return *this;
     }
 

Framework/Units/testUnits.cc

@@ -20,6 +20,7 @@ TEST_CASE("PhysicalUnits", "[Units]") {
     REQUIRE(E1 == 10_GeV);
 
     LengthType l1 = 10_nm;
+    l1=l1;
 
     LengthType arr0[5];
     arr0[0] = 5_m;