diff --git a/Processes/QGSJetII/QGSJetIIStack.h b/Processes/QGSJetII/QGSJetIIStack.h index 8e3c87ddc9581464428809e86f8cce1dde87623a..04685ab7cf0a3efc89f6c953b6c3f0354758003c 100644 --- a/Processes/QGSJetII/QGSJetIIStack.h +++ b/Processes/QGSJetII/QGSJetIIStack.h @@ -86,7 +86,7 @@ namespace corsika::process::qgsjetII { public: void SetParticleData(const int vID, const corsika::units::si::HEPEnergyType vE, const MomentumVector& vP, - const corsika::units::si::HEPMassType vM) { + const corsika::units::si::HEPMassType) { SetPID(vID); SetEnergy(vE); SetMomentum(vP); @@ -95,7 +95,7 @@ namespace corsika::process::qgsjetII { void SetParticleData(ParticleInterface<StackIteratorInterface>& /*parent*/, const int vID, const corsika::units::si::HEPEnergyType vE, const MomentumVector& vP, - const corsika::units::si::HEPMassType vM) { + const corsika::units::si::HEPMassType) { SetPID(vID); SetEnergy(vE); SetMomentum(vP); diff --git a/Processes/QGSJetII/testQGSJetII.cc b/Processes/QGSJetII/testQGSJetII.cc index d9a3dcda735ef3c2e941cc760b1f5389dc7bfd48..0a057ceb8cb398d82d2d0a387357c3c00462ea24 100644 --- a/Processes/QGSJetII/testQGSJetII.cc +++ b/Processes/QGSJetII/testQGSJetII.cc @@ -143,8 +143,17 @@ TEST_CASE("QgsjetIIInterface", "[processes]") { [[maybe_unused]] const GrammageType length = model.GetInteractionLength(particle); CHECK(length / (1_g / square(1_cm)) == Approx(93.47).margin(0.1)); - CHECK(view.GetSize() == 14); - CHECK(sumCharge(view) == 2); + + /*********************************** + It as turned out already two times (#291 and #307) that the detailed output of QGSJetII + event generation depends on the gfortran version used. This is not reliable and cannot + be tested in a unit test here. + One related problem was already found (#291) and is realted to undefined behaviour in the + evaluation of functions in logical expressions. It is not clear if #307 is the same issue. + + CHECK(view.GetSize() == 14); + CHECK(sumCharge(view) == 2); + ************************************/ auto const secMomSum = sumMomentum(view, projectileMomentum.GetCoordinateSystem()); CHECK((secMomSum - projectileMomentum).norm() / projectileMomentum.norm() == Approx(0).margin(1e-2));