From 69385049218c60bb04bcb5ba92550823be134c36 Mon Sep 17 00:00:00 2001
From: ralfulrich <ralf.ulrich@kit.edu>
Date: Sat, 29 May 2021 08:48:31 +0200
Subject: [PATCH] compiler warnings
---
corsika/detail/output/OutputManager.inl | 14 ++++++++++++--
corsika/modules/sibyll/Interaction.hpp | 1 -
corsika/output/NoOutput.hpp | 2 +-
tests/modules/testSibyll.cpp | 3 +++
4 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/corsika/detail/output/OutputManager.inl b/corsika/detail/output/OutputManager.inl
index 6a4ec6204..1fa7e0267 100644
--- a/corsika/detail/output/OutputManager.inl
+++ b/corsika/detail/output/OutputManager.inl
@@ -194,7 +194,12 @@ namespace corsika {
if (state_ == OutputState::NoInit) { startOfLibrary(); }
// now start the event for all the outputs
- for (auto& [name, output] : outputs_) { output.get().startOfShower(); }
+ for (auto& [name, output] : outputs_) {
+ {
+ [[maybe_unused]] auto const& dummy_name = name;
+ }
+ output.get().startOfShower();
+ }
// increment our shower count
++count_;
@@ -205,7 +210,12 @@ namespace corsika {
inline void OutputManager::endOfShower() {
- for (auto& [name, output] : outputs_) { output.get().endOfShower(); }
+ for (auto& [name, output] : outputs_) {
+ {
+ [[maybe_unused]] auto const& dummy_name = name;
+ }
+ output.get().endOfShower();
+ }
// switch back to the initialized state
state_ = OutputState::LibraryReady;
diff --git a/corsika/modules/sibyll/Interaction.hpp b/corsika/modules/sibyll/Interaction.hpp
index 81f0aa685..c00c68ac9 100644
--- a/corsika/modules/sibyll/Interaction.hpp
+++ b/corsika/modules/sibyll/Interaction.hpp
@@ -57,7 +57,6 @@ namespace corsika::sibyll {
HEPEnergyType getMaxEnergyCoM() const { return maxEnergyCoM_; }
default_prng_type& RNG_ = RNGManager::getInstance().getRandomStream("sibyll");
- const bool internalDecays_ = true;
const HEPEnergyType minEnergyCoM_ = 10. * 1e9 * electronvolt;
const HEPEnergyType maxEnergyCoM_ = 1.e6 * 1e9 * electronvolt;
const int maxTargetMassNumber_ = 18;
diff --git a/corsika/output/NoOutput.hpp b/corsika/output/NoOutput.hpp
index 289c19ad7..abee413e0 100644
--- a/corsika/output/NoOutput.hpp
+++ b/corsika/output/NoOutput.hpp
@@ -45,7 +45,7 @@ namespace corsika {
/**
* Get the configuration of this output.
*/
- YAML::Node getConfig() const { return YAML::Node(); };
+ YAML::Node getConfig() const override { return YAML::Node(); };
/**
* Get any summary information for the entire library.
diff --git a/tests/modules/testSibyll.cpp b/tests/modules/testSibyll.cpp
index f6a517e1a..41f511a47 100644
--- a/tests/modules/testSibyll.cpp
+++ b/tests/modules/testSibyll.cpp
@@ -255,6 +255,7 @@ TEST_CASE("SibyllInterface", "[processes]") {
const HEPEnergyType P0 = 1000_EeV;
auto [stack, viewPtr] = setup::testing::setup_stack(
Code::Proton, 0, 0, P0, (setup::Environment::BaseNodeType* const)nodePtr, cs);
+ { [[maybe_unused]] auto const& dummy1 = stack; }
MomentumVector plab =
MomentumVector(cs, {P0, 0_eV, 0_eV}); // this is secret knowledge about setupStack
setup::StackView& view = *viewPtr;
@@ -265,10 +266,12 @@ TEST_CASE("SibyllInterface", "[processes]") {
SECTION("InteractionInterface - target nucleus out of range") {
auto [env1, csPtr1, nodePtr1] = setup::testing::setup_environment(Code::Argon);
+ { [[maybe_unused]] auto const& dummy1 = env1; }
auto const& cs1 = *csPtr1;
const HEPEnergyType P0 = 150_GeV;
auto [stack, viewPtr] = setup::testing::setup_stack(
Code::Electron, 0, 0, P0, (setup::Environment::BaseNodeType* const)nodePtr1, cs1);
+ { [[maybe_unused]] auto const& dummy1 = stack; }
MomentumVector plab = MomentumVector(
cs1, {P0, 0_eV, 0_eV}); // this is secret knowledge about setupStack
setup::StackView& view = *viewPtr;
--
GitLab