From 51c99a612f7c935186e2e149555d46ddf5a34ae4 Mon Sep 17 00:00:00 2001
From: ralfulrich <ralf.ulrich@kit.edu>
Date: Sat, 29 May 2021 15:13:29 +0200
Subject: [PATCH] coverage

---
 tests/framework/testStackInterface.cpp | 6 +++++-
 tests/modules/testSibyll.cpp           | 8 +++++---
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/tests/framework/testStackInterface.cpp b/tests/framework/testStackInterface.cpp
index 1bb77d166..6b6c26ea3 100644
--- a/tests/framework/testStackInterface.cpp
+++ b/tests/framework/testStackInterface.cpp
@@ -29,7 +29,7 @@ TEST_CASE("Stack", "[Stack]") {
   logging::set_level(logging::level::info);
 
   // helper function for sum over stack data
-  auto sum = [](const StackTest& stack) {
+  auto sum = [](StackTest const& stack) {
     double v = 0;
     for (const auto& p : stack) v += p.getData();
     return v;
@@ -66,6 +66,8 @@ TEST_CASE("Stack", "[Stack]") {
     stack.addParticle(std::tuple{9.9});
     const double v = sum(stack);
     CHECK(v == 9.9);
+    auto const particle_const = stack.begin();
+    CHECK(particle_const.getData() == 9.9);
   }
 
   SECTION("delete from stack") {
@@ -80,7 +82,9 @@ TEST_CASE("Stack", "[Stack]") {
     p.setData(9.9);
     CHECK(stack.getSize() == 1);
     CHECK(stack.getEntries() == 1);
+    CHECK(!p.isErased());
     stack.erase(p);
+    CHECK(p.isErased());
     CHECK(stack.getSize() == 1);
     CHECK(stack.getEntries() == 0);
   }
diff --git a/tests/modules/testSibyll.cpp b/tests/modules/testSibyll.cpp
index 3f0c89e08..f544204c2 100644
--- a/tests/modules/testSibyll.cpp
+++ b/tests/modules/testSibyll.cpp
@@ -30,7 +30,7 @@
 using namespace corsika;
 using namespace corsika::sibyll;
 
-TEST_CASE("Sibyll", "[processes]") {
+TEST_CASE("Sibyll", "modules") {
 
   logging::set_level(logging::level::info);
 
@@ -99,13 +99,13 @@ auto sumMomentum(TStackView const& view, CoordinateSystemPtr const& vCS) {
   return sum;
 }
 
-TEST_CASE("SibyllInterface", "[processes]") {
+TEST_CASE("SibyllInterface", "modules") {
 
   logging::set_level(logging::level::info);
 
   auto [env, csPtr, nodePtr] = setup::testing::setup_environment(Code::Oxygen);
   auto const& cs = *csPtr;
-  [[maybe_unused]] auto const& env_dummy = env;
+  { [[maybe_unused]] auto const& env_dummy = env; }
 
   RNGManager<>::getInstance().registerRandomStream("sibyll");
 
@@ -133,6 +133,8 @@ TEST_CASE("SibyllInterface", "[processes]") {
     CHECK(xs_ela_pp == xs_ela_pHydrogen);
     CHECK(xs_ela_pn == xs_ela_pHydrogen);
 
+    CHECK_THROWS(convertFromSibyll(corsika::sibyll::SibyllCode::Unknown));
+
     // out of range
     // beam particle
     CHECK_THROWS(
-- 
GitLab