@@ -22,16 +22,16 @@ Until all boxes below are checked the reviewer gets back to the contributor and
Concrete rules are listed here. Make a copy of the below section in the MR discussion section and go through all the points:
```
- [] The MR has the Tag "ready for code review", and is without WIP (work in progress) status
- [] Make sure the most recent CI jobs (config, quality, build, tests) all run fine with no failures
- [] The MR has the Tag "ready for code review", and is without WIP (work in progress) status
- [] Make sure the most recent CI jobs (config, quality, build, tests) all run fine with no failures
- if "check clang-format" failed: the code contributor has to run `./do-clang-format.py --apply` eventually with the `--all` option
- if "check copyright" failed the code contributor has to run`./do-copyright.py --add=20xy`
- [] Also run the extra optional jobs "coverage", "release-clang-8", "release-u-18.04" and make sure no problems occur
- [] Check in the "coverage" job output that the coverage did not decreased (!). It should always stay, or increase. If it decreased --> add further unit tests, and check coverage report.
- [] Also run the extra optional jobs "coverage", "release-clang-8", "release-u-18.04" and make sure no problems occur
- [] Check in the "coverage" job output that the coverage did not decreased (!). It should always stay, or increase. If it decreased --> add further unit tests, and check coverage report.
- On the MR page, open the "Open in Web IDE" tool
- [] Check if the provided solution solves the Issue, discuss on gitlab
- [] Check that all changes are actually related to the issue
- [] There are no debug statements left, not even commented out
- [] Check all changes for coding rules and guidelines
- [] **Click here to approve this MR for merging**
- [] Check if the provided solution solves the Issue, discuss on gitlab
- [] Check that all changes are actually related to the issue
- [] There are no debug statements left, not even commented out
- [] Check all changes for coding rules and guidelines
- [] **Click here to approve this MR for merging**
