IAP GITLAB
Changes
Page history
Update Code Approval Procedure
authored
Jul 13, 2020
by
Ralf Ulrich
Show whitespace changes
Inline
Side-by-side
Code-Approval-Procedure.md
View page @
f3c94ddd
...
...
@@ -16,7 +16,7 @@ A merge request is not complete, if there are no Labels assigned. Labels help th
-
Specify, if needed: Critical (must be addressed immediately), Important (blocks other things)
-
Describe the scope: Stack, Documentation, Processes, Build System, Testing, Style, ... (add further items if needed)
In the following graph the typical default workflow is described:
In the following graph the typical default workflow is described
. It is important that you also read
[
this
](
Coding
)
:
```
mermaid
graph TD;
...
...
@@ -36,7 +36,7 @@ graph TD;
A007 --> A0
A0[Working on MR/branch] -- Finished main work --> A2[Make sure all conditions for code review and approval are met
, Read [coding](Coding)
];
A0[Working on MR/branch] -- Finished main work --> A2[Make sure all conditions for code review and approval are met];
A2 -- Ok --> A3[Remove 'WIP' status];
A3 --> A4[Inform developers/corsika-devel that code review can proceed];
end
...
...
...
...