... | ... | @@ -61,7 +61,7 @@ Concrete rules are listed here. Make a copy of the below section in the MR discu |
|
|
The code approval procedure is described in the wiki: [Code approval procedure wiki](https://gitlab.ikp.kit.edu/AirShowerPhysics/corsika/-/wikis/Code-Approval-Procedure)
|
|
|
|
|
|
- [ ] The MR is without WIP (work in progress) status
|
|
|
- [ ] Make sure the most recent CI jobs (config, quality, build, tests) all run fine with no failures
|
|
|
- [ ] Make sure the most recent CI jobs (config, quality, build, test, example) all run fine with no failures
|
|
|
- if "check clang-format" failed: the code contributor has to run `./do-clang-format.py --apply` eventually with the `--all` option
|
|
|
- if "check copyright" failed the code contributor has to run`./do-copyright.py --add=20xy`
|
|
|
- [ ] Also run all the extra optional jobs "coverage", "release-clang-8", "release-u-18.04" and make sure no problems occur
|
... | ... | |