IAP GITLAB
Changes
Page history
Update Code Approval Procedure
authored
Jul 17, 2020
by
Ralf Ulrich
Show whitespace changes
Inline
Side-by-side
Code-Approval-Procedure.md
View page @
5ba1690f
...
@@ -63,8 +63,8 @@ graph TD;
...
@@ -63,8 +63,8 @@ graph TD;
C2 -.-> C2b[NOTE: this will also trigger the `optional` jobs on gitlab-CI. Make sure the CI jobs still succeed.];
C2 -.-> C2b[NOTE: this will also trigger the `optional` jobs on gitlab-CI. Make sure the CI jobs still succeed.];
C2c -.-> C2b;
C2c -.-> C2b;
C3 -.-> C2b;
C3 -.-> C2b;
C3 --> C4[
Fina
l check mark means REVIEW IS FINISHED];
C3 --> C4[
If al
l check mark
s are done: this
means REVIEW IS FINISHED];
C4 --> C5[Add label `
Approved for merging
`];
C4 --> C5[Add label `
Code review finished
`];
end
end
subgraph "Project owner"
subgraph "Project owner"
...
@@ -96,6 +96,6 @@ The code approval procedure is described in the wiki: [Code approval procedure w
...
@@ -96,6 +96,6 @@ The code approval procedure is described in the wiki: [Code approval procedure w
- [ ] Check that all changes are actually related to the issue
- [ ] Check that all changes are actually related to the issue
- [ ] There are no debug statements left, not even commented out
- [ ] There are no debug statements left, not even commented out
- [ ] Check all changes for coding rules and guidelines
- [ ] Check all changes for coding rules and guidelines
- When all above is done
- When all above is done
:
-
[ ]
**Add label "Code Review Finished"**
- **Add
MR
label "Code Review Finished"**
```
```