... | ... | @@ -63,8 +63,8 @@ graph TD; |
|
|
C2 -.-> C2b[NOTE: this will also trigger the `optional` jobs on gitlab-CI. Make sure the CI jobs still succeed.];
|
|
|
C2c -.-> C2b;
|
|
|
C3 -.-> C2b;
|
|
|
C3 --> C4[Final check mark means REVIEW IS FINISHED];
|
|
|
C4 --> C5[Add label `Approved for merging`];
|
|
|
C3 --> C4[If all check marks are done: this means REVIEW IS FINISHED];
|
|
|
C4 --> C5[Add label `Code review finished`];
|
|
|
end
|
|
|
|
|
|
subgraph "Project owner"
|
... | ... | @@ -96,6 +96,6 @@ The code approval procedure is described in the wiki: [Code approval procedure w |
|
|
- [ ] Check that all changes are actually related to the issue
|
|
|
- [ ] There are no debug statements left, not even commented out
|
|
|
- [ ] Check all changes for coding rules and guidelines
|
|
|
- When all above is done
|
|
|
- [ ] **Add label "Code Review Finished"**
|
|
|
- When all above is done:
|
|
|
- **Add MR label "Code Review Finished"**
|
|
|
``` |