... | ... | @@ -22,6 +22,8 @@ Until all boxes below are checked the reviewer gets back to the contributor and |
|
|
|
|
|
Concrete rules are listed here. Make a copy of the below section in the MR discussion section and go through all the points:
|
|
|
```
|
|
|
The code approval procedure is described in the wiki: [Code approval procedure wiki](https://gitlab.ikp.kit.edu/AirShowerPhysics/corsika/-/wikis/Code-Approval-Procedure)
|
|
|
|
|
|
- [ ] The MR has the Tag "ready for code review", and is without WIP (work in progress) status
|
|
|
- [ ] Make sure the most recent CI jobs (config, quality, build, tests) all run fine with no failures
|
|
|
- if "check clang-format" failed: the code contributor has to run `./do-clang-format.py --apply` eventually with the `--all` option
|
... | ... | |