D1 --> D2[Rediscuss with contributor and reviewer, if needed]
D1 --> D3[Put MR on agenda of next meeting, if usefull]
D1 --> D2[Re-discuss with contributor and reviewer, if needed]
D1 --> D3[Put MR on agenda of next meeting, if useful]
D1 --> D4[MR is merged into master, and MR is closed]
D2 --> D4
D3 --> D4
...
...
@@ -72,12 +72,12 @@ Concrete rules are listed here. Make a copy of the below section in the MR discu
```
The code approval procedure is described in the wiki: [Code approval procedure wiki](https://gitlab.ikp.kit.edu/AirShowerPhysics/corsika/-/wikis/Code-Approval-Procedure)
- [ ] The MR is without WIP (work in progress) status
- [ ] Make sure the most recent CI jobs (config, quality, build, test, example) all run fine with no failures
- [ ] The MR is without `WIP` (work in progress) status
- [ ] Make sure the most recent CI jobs (config, quality, build_test_example) all run fine with no failures
- if "check clang-format" failed: the code contributor has to run `./do-clang-format.py --apply` eventually with the `--all` option
- if "check copyright" failed the code contributor has to run`./do-copyright.py --add=20xy`
- [ ] Also run all the extra optional jobs "coverage", "release-clang-8", "release-u-18.04" and make sure no problems occur
- [ ] Check in the "coverage" job output that the coverage did not decreases (!). It should always stay, or increase. If it decreased --> ask contributor to add further unit tests, and check coverage report.
- [ ] Make sure also the jobs with label `ready for code review` succeed. This includes the optional jobs, in particular 'coverage', 'release-clang-8", "release-u-18.04" and make sure no problems occur
- [ ] Check in the "coverage" job output that the coverage did not decreases. It should always stay, or increase. If it decreased --> ask contributor to add further needed unit tests, and check coverage report.
- On the MR page, open the "Open in Web IDE" tool
- [ ] Check if the provided solution solves the Issue, discuss on gitlab
- [ ] Check that all changes are actually related to the issue
