IAP GITLAB
Changes
Page history
Update Code Approval Procedure
authored
Jan 26, 2021
by
Ralf Ulrich
Show whitespace changes
Inline
Side-by-side
Code-Approval-Procedure.md
View page @
0df1b918
...
...
@@ -65,10 +65,11 @@ graph TD;
C3 -.-> C2b;
C3 --> C4[If all check marks are done: this means REVIEW IS FINISHED];
C4 --> C5[Add label `Code review finished`];
C5 --> C6[Rebase, if needed]
end
subgraph "Project owner"
C
5
--> D1[Checks the MR and the review]
C
6
--> D1[Checks the MR and the review]
D1 --> D2[Re-discuss with contributor and reviewer, if needed]
D1 --> D3[Put MR on agenda of next meeting, if useful]
D1 ==> D4[MR is merged into master, and MR is closed]
...
...
@@ -98,4 +99,7 @@ The code approval procedure is described in the wiki: [Code approval procedure w
- [ ] Check all changes for coding rules and guidelines
- When all above is done:
- **Add MR label "Code Review Finished"**
- Rebase, if needed. If unclear: discuss!
- [ ] rebased
- [ ] not rebased
```