Warnings to fix
Projects should compile without warnings, at least to their own warning standards. This is not so easy, because some warnings are only thrown by some compiler versions. On OSX, I am getting these warnings:
In file included from /Users/hdembins/Code/corsika/Documentation/Examples/logger_example.cc:12:
/Users/hdembins/Code/corsika/build/include/corsika/logging/Logger.h:89:16: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension
[-Wgnu-zero-variadic-macro-arguments]
##__VA_ARGS__);
^
/Users/hdembins/Code/corsika/build/include/corsika/logging/Logger.h:89:16: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension
[-Wgnu-zero-variadic-macro-arguments]
/Users/hdembins/Code/corsika/build/include/corsika/logging/Logger.h:89:16: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension
[-Wgnu-zero-variadic-macro-arguments]
/Users/hdembins/Code/corsika/Framework/Units/testUnits.cc:36:8: warning: explicitly assigning value of variable of type
'corsika::units::si::LengthType' (aka 'quantity<dimensions<1, 0, 0, 0, 0, 0, 0, 0>, double>') to itself [-Wself-assign-overloaded]
l1 = l1;
~~ ^ ~~
3 warnings generated.
I am not sure how to fix the first one, but relying on compiler extensions is not good. The second may be avoidable by writing the test a bit differently, I have to look into it.