From ff26947917d24a227a58b8a0681c98dd2e66049c Mon Sep 17 00:00:00 2001
From: Alan Coleman <alanco@umich.edu>
Date: Mon, 11 Mar 2024 11:22:28 +0000
Subject: [PATCH] Clean up Signal/SignalPath
---
corsika/detail/framework/geometry/Path.inl | 7 ++-----
corsika/detail/modules/radio/propagators/SignalPath.inl | 2 --
corsika/modules/radio/propagators/RadioPropagator.hpp | 6 +++---
3 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/corsika/detail/framework/geometry/Path.inl b/corsika/detail/framework/geometry/Path.inl
index 4ba3d1ba8..0ff9d44d3 100644
--- a/corsika/detail/framework/geometry/Path.inl
+++ b/corsika/detail/framework/geometry/Path.inl
@@ -10,14 +10,11 @@
#include <deque>
-#include <corsika/framework/geometry/Point.hpp>
-#include <corsika/framework/core/PhysicalUnits.hpp>
-
namespace corsika {
- Path::Path(Point const& point) { points_.push_front(point); }
+ inline Path::Path(Point const& point) { points_.push_front(point); }
- Path::Path(std::deque<Point> const& points)
+ inline Path::Path(std::deque<Point> const& points)
: points_(points) {
int dequesize_ = points.size();
if (dequesize_ == 0 || dequesize_ == 1) {
diff --git a/corsika/detail/modules/radio/propagators/SignalPath.inl b/corsika/detail/modules/radio/propagators/SignalPath.inl
index 7de9c8419..b11535822 100644
--- a/corsika/detail/modules/radio/propagators/SignalPath.inl
+++ b/corsika/detail/modules/radio/propagators/SignalPath.inl
@@ -8,8 +8,6 @@
#pragma once
-#include <corsika/modules/radio/propagators/SignalPath.hpp>
-
namespace corsika {
inline SignalPath::SignalPath(
diff --git a/corsika/modules/radio/propagators/RadioPropagator.hpp b/corsika/modules/radio/propagators/RadioPropagator.hpp
index 599ada07f..236a7b7b9 100644
--- a/corsika/modules/radio/propagators/RadioPropagator.hpp
+++ b/corsika/modules/radio/propagators/RadioPropagator.hpp
@@ -20,9 +20,9 @@ namespace corsika {
* to be used as a RadioPropagator must implement the
* following methods:
*
- * SignalPathCollection Propagate(Point const& start,
- * Point const& end,
- * LengthType const stepsize);
+ * SignalPathCollection Propagate(Particle const& particle,
+ * Point const& source,
+ Point const& destination) const
*/
template <typename TImpl, typename TEnvironment>
class RadioPropagator {
--
GitLab