From 96542df43e837c8ed7c7d6f2728ac002a20dba72 Mon Sep 17 00:00:00 2001
From: Jean-Marco Alameddine <jean-marco.alameddine@udo.edu>
Date: Mon, 8 May 2023 09:27:33 +0200
Subject: [PATCH] address MR comments
---
tests/framework/testCascade.cpp | 2 +-
tests/framework/testProcessSequence.cpp | 16 +++-------------
2 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/tests/framework/testCascade.cpp b/tests/framework/testCascade.cpp
index 4d74f1807..482e68455 100644
--- a/tests/framework/testCascade.cpp
+++ b/tests/framework/testCascade.cpp
@@ -179,7 +179,7 @@ public:
int getCalls() const { return calls_; }
private:
- int maxCalls_;
+ const int maxCalls_;
int calls_ = 0;
};
diff --git a/tests/framework/testProcessSequence.cpp b/tests/framework/testProcessSequence.cpp
index c24c9be54..2686b2cca 100644
--- a/tests/framework/testProcessSequence.cpp
+++ b/tests/framework/testProcessSequence.cpp
@@ -1068,17 +1068,10 @@ TEST_CASE("ProcessSequence Indexing", "ProcessSequence") {
class ProcessZero : public InteractionProcess<ProcessZero> {
public:
- ProcessZero(int const v)
- : v_(v) {
- CORSIKA_LOG_DEBUG(
- "globalCount: {}"
- ", v_: {}",
- globalCount, v_);
- globalCount++;
- }
+ ProcessZero() = default;
template <typename TView>
- void doInteraction(TView& v, Code const, Code const, FourMomentum const&,
+ void doInteraction(TView&, Code const, Code const, FourMomentum const&,
FourMomentum const&) const {
FAIL("ProcessZero::doInteraction has been called!");
}
@@ -1088,16 +1081,13 @@ public:
CORSIKA_LOG_DEBUG("ProcessZero::getCrossSection");
return 0_mb;
}
-
-private:
- int v_ = 0;
};
TEST_CASE("SelectInteractionZeroCrossSection", "ProcessSequence") {
logging::set_level(logging::level::info);
CoordinateSystemPtr rootCS = get_root_CoordinateSystem();
- auto sequence = make_sequence(ProcessZero(0));
+ auto sequence = make_sequence(ProcessZero());
DummyData particle;
DummyTrajectory track;
--
GitLab