From 83a12df11ebc3e00c35028184f9ddfe7cef21b10 Mon Sep 17 00:00:00 2001
From: Maximilian Reininghaus <maximilian.reininghaus@kit.edu>
Date: Thu, 11 Apr 2019 18:37:38 -0300
Subject: [PATCH] reordered walk()

---
 Environment/VolumeTreeNode.h | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/Environment/VolumeTreeNode.h b/Environment/VolumeTreeNode.h
index 7a8b2e785..d99675862 100644
--- a/Environment/VolumeTreeNode.h
+++ b/Environment/VolumeTreeNode.h
@@ -75,15 +75,12 @@ namespace corsika::environment {
      */
     template <typename TCallable, bool preorder = true>
     void walk(TCallable func) {
-      if constexpr (preorder) {
-        func(*this);
-        std::for_each(fChildNodes.begin(), fChildNodes.end(),
-                      [&](auto& v) { v->walk(func); });
-      } else {
-        std::for_each(fChildNodes.begin(), fChildNodes.end(),
-                      [&](auto& v) { v->walk(func); });
-        func(*this);
-      }
+      if constexpr (preorder) { func(*this); }
+
+      std::for_each(fChildNodes.begin(), fChildNodes.end(),
+                    [&](auto& v) { v->walk(func); });
+
+      if constexpr (!preorder) { func(*this); };
     }
 
     void AddChild(VTNUPtr pChild) {
-- 
GitLab