diff --git a/conan-install.sh b/conan-install.sh index 5fcf2b2b7601bdb72ba5d57313b9f1c2a454941b..4e3ed734c347199e5ce05e76fd3fbaf5803d923c 100755 --- a/conan-install.sh +++ b/conan-install.sh @@ -9,5 +9,5 @@ if ! conan profile show corsika8 >/dev/null 2>/dev/null; then conan profile update settings.compiler.libcxx=libstdc++11 corsika8 fi fi - -conan install -pr corsika8 --build=missing ${DIR} +# force rebuild of cubicinterpolation (see discussion in MR509) +conan install -pr corsika8 --build=missing --build=cubicinterpolation ${DIR} diff --git a/conanfile.txt b/conanfile.txt index 351e9f3b4be3fe99b2e47429ec6c666e7c257d49..d7e6ade75ac6162e8af92dc27a1b458f54208503 100644 --- a/conanfile.txt +++ b/conanfile.txt @@ -2,7 +2,7 @@ spdlog/1.9.2 catch2/2.13.8 eigen/3.3.8 -boost/1.76.0 +boost/1.78.0 zlib/1.2.11 proposal/7.4.2 yaml-cpp/0.7.0 diff --git a/corsika/detail/framework/stack/Stack.inl b/corsika/detail/framework/stack/Stack.inl index 314e89e959b59f69e0cd6b481cf31809c11daed2..a463a642f9dc8ed3293350993e5b1a4138ec3062 100644 --- a/corsika/detail/framework/stack/Stack.inl +++ b/corsika/detail/framework/stack/Stack.inl @@ -348,7 +348,7 @@ namespace corsika { inline void Stack<StackData, MParticleInterface, MSecondaryProducer>::swap( unsigned int const a, unsigned int const b) { data_.swap(a, b); - std::swap(deleted_[a], deleted_[b]); + std::vector<bool>::swap(deleted_[a], deleted_[b]); } template <typename StackData, template <typename> typename MParticleInterface, diff --git a/corsika/detail/modules/thinning/EMThinning.inl b/corsika/detail/modules/thinning/EMThinning.inl index 29ed5ad46d2268700b505fde6f386782cf06e8bc..1a9982f7974ea4196f0f0d19126714a321791209 100644 --- a/corsika/detail/modules/thinning/EMThinning.inl +++ b/corsika/detail/modules/thinning/EMThinning.inl @@ -13,10 +13,11 @@ namespace corsika { - EMThinning::EMThinning(HEPEnergyType threshold, double maxWeight, bool const eraseParticles) + EMThinning::EMThinning(HEPEnergyType threshold, double maxWeight, + bool const eraseParticles) : threshold_{threshold} , maxWeight_{maxWeight} - , eraseParticles_ {eraseParticles} {} + , eraseParticles_{eraseParticles} {} template <typename TStackView> void EMThinning::doSecondaries(TStackView& view) { @@ -79,11 +80,11 @@ namespace corsika { // erase discared particles in case of multithinning if (eraseParticles_) { - for (auto& p : view) { - if (auto const w = p.getWeight(); w == 0) { p.erase(); } - } - } else { - return; + for (auto& p : view) { + if (auto const w = p.getWeight(); w == 0) { p.erase(); } + } + } else { + return; } } diff --git a/corsika/modules/thinning/EMThinning.hpp b/corsika/modules/thinning/EMThinning.hpp index a32c05a6345d533217c0b1653b8ecfb6886d5308..3c746194e37cc837bc979352871cb6bf4a1a4a0a 100644 --- a/corsika/modules/thinning/EMThinning.hpp +++ b/corsika/modules/thinning/EMThinning.hpp @@ -28,7 +28,8 @@ namespace corsika { * @param threshold: thinning applied below this energy * @param maxWeight: maximum allowed weight */ - EMThinning(HEPEnergyType threshold, double maxWeight, bool const eraseParticles=true); + EMThinning(HEPEnergyType threshold, double maxWeight, + bool const eraseParticles = true); /** * Apply thinning to secondaries. Only EM primaries with two EM secondaries are diff --git a/tests/framework/testSaveBoostHistogram.cpp b/tests/framework/testSaveBoostHistogram.cpp index 89182311a650e76968226e3dc2cf5a97c8b4e29a..ca772e11c971542783b28521724daaca08e2ee76 100644 --- a/tests/framework/testSaveBoostHistogram.cpp +++ b/tests/framework/testSaveBoostHistogram.cpp @@ -25,7 +25,8 @@ TEST_CASE("SaveHistogram") { std::uniform_real_distribution<double> r{-3, 3}; auto h = bh::make_histogram( - bh::axis::regular{5, 0, 10, "normal"}, bh::axis::regular{3, 0, 4, "exponential"}, + bh::axis::regular{5, 0., 10., "normal"}, + bh::axis::regular{3, 0., 4., "exponential"}, bh::axis::category<int>{{2, 3, 5, 7}, "integer category"}, bh::axis::regular<double, bh::use_default, bh::use_default, bh::axis::option::growth_t>{10, -1, 1, "integer category"});