From 699214a4a5158586421d008d0cc26bb013995d50 Mon Sep 17 00:00:00 2001
From: Nikos Karastathis <n.karastathis@kit.edu>
Date: Mon, 4 Jul 2022 15:01:42 +0200
Subject: [PATCH] Implement Max's comments during code review
---
.../detail/framework/geometry/FourVector.inl | 4 +-
corsika/detail/modules/TimeCut.inl | 2 +-
corsika/detail/modules/radio/RadioProcess.inl | 2 +-
corsika/detail/modules/radio/ZHS.inl | 24 ++++++------
.../modules/radio/detectors/RadioDetector.inl | 2 +-
.../radio/propagators/RadioPropagator.inl | 4 +-
.../modules/radio/propagators/SignalPath.inl | 8 ++--
.../radio/propagators/SimplePropagator.inl | 22 +++++------
.../radio/propagators/StraightPropagator.inl | 38 +++++++++----------
corsika/framework/core/PhysicalUnits.hpp | 4 +-
corsika/modules/TimeCut.hpp | 2 +-
corsika/modules/radio/CoREAS.hpp | 2 +-
corsika/modules/radio/RadioProcess.hpp | 9 ++---
corsika/modules/radio/ZHS.hpp | 2 +-
.../modules/radio/detectors/RadioDetector.hpp | 2 +-
.../radio/propagators/RadioPropagator.hpp | 2 +-
.../modules/radio/propagators/SignalPath.hpp | 12 +++---
.../radio/propagators/SimplePropagator.hpp | 2 +-
.../radio/propagators/StraightPropagator.hpp | 2 +-
19 files changed, 71 insertions(+), 74 deletions(-)
diff --git a/corsika/detail/framework/geometry/FourVector.inl b/corsika/detail/framework/geometry/FourVector.inl
index 62542aae5..7219a920b 100644
--- a/corsika/detail/framework/geometry/FourVector.inl
+++ b/corsika/detail/framework/geometry/FourVector.inl
@@ -54,8 +54,8 @@ namespace corsika {
}
template <typename TTimeType, typename TSpaceVecType>
- inline FourVector<TTimeType, TSpaceVecType>&
- FourVector<TTimeType, TSpaceVecType>::operator+=(FourVector const& b) {
+ inline FourVector<TTimeType, TSpaceVecType>& FourVector<TTimeType, TSpaceVecType>::
+ operator+=(FourVector const& b) {
timeLike_ += b.timeLike_;
spaceLike_ += b.spaceLike_;
diff --git a/corsika/detail/modules/TimeCut.inl b/corsika/detail/modules/TimeCut.inl
index 47501280f..13c9df053 100644
--- a/corsika/detail/modules/TimeCut.inl
+++ b/corsika/detail/modules/TimeCut.inl
@@ -16,7 +16,7 @@ namespace corsika {
: time_(time) {}
template <typename Particle, typename Track>
- inline ProcessReturn TimeCut::doContinuous(Particle& particle, Track const&,
+ inline ProcessReturn TimeCut::doContinuous(Particle const& particle, Track const&,
bool const) {
CORSIKA_LOG_TRACE("TimeCut::doContinuous");
if (particle.getTime() >= time_) {
diff --git a/corsika/detail/modules/radio/RadioProcess.inl b/corsika/detail/modules/radio/RadioProcess.inl
index d871ebf43..8198a3665 100644
--- a/corsika/detail/modules/radio/RadioProcess.inl
+++ b/corsika/detail/modules/radio/RadioProcess.inl
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
diff --git a/corsika/detail/modules/radio/ZHS.inl b/corsika/detail/modules/radio/ZHS.inl
index 70ff223e3..29f175e0a 100644
--- a/corsika/detail/modules/radio/ZHS.inl
+++ b/corsika/detail/modules/radio/ZHS.inl
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
@@ -19,13 +19,13 @@ namespace corsika {
auto const startTime{particle.getTime()};
auto const endTime{particle.getTime() + track.getDuration()};
- if (startTime - endTime == 0_s) {
+ if (startTime == endTime) {
return ProcessReturn::Ok;
} else {
auto const startPoint{track.getPosition(0)};
auto const endPoint{track.getPosition(1)};
- LengthType trackLength{(startPoint - endPoint).getNorm()};
+ LengthType const trackLength{(startPoint - endPoint).getNorm()};
auto const betaModule{(endPoint - startPoint).getNorm() /
(constants::c * (endTime - startTime))};
@@ -35,8 +35,8 @@ namespace corsika {
// // get "mid" position of the track geometrically
- auto halfVector{(startPoint - endPoint) / 2};
- auto midPoint{endPoint + halfVector};
+ auto const halfVector{(startPoint - endPoint) / 2};
+ auto const midPoint{endPoint + halfVector};
auto const constants{charge / (4 * M_PI) / (constants::epsilonZero) / constants::c};
@@ -61,11 +61,11 @@ namespace corsika {
auto point1{startPoint};
TimeType time1{startTime};
for (int j{0}; j < nSubTracks; j++) {
- auto point2{point1 + step};
- TimeType time2{time1 + timeStep};
- auto newHalfVector{(point1 - point2) / 2.};
- auto newMidPoint{point2 + newHalfVector};
- auto newMidPaths{
+ auto const point2{point1 + step};
+ TimeType const time2{time1 + timeStep};
+ auto const newHalfVector{(point1 - point2) / 2.};
+ auto const newMidPoint{point2 + newHalfVector};
+ auto const newMidPaths{
this->propagator_.propagate(newMidPoint, antenna.getLocation(), 1_m)};
// A function for calculating the field should be made since it is repeated
// later
@@ -74,7 +74,7 @@ namespace corsika {
double const n_source{newMidPaths[k].refractive_index_source_};
double const betaTimesK{beta.dot(newMidPaths[k].emit_)};
- TimeType midTime{(time1 + time2) / 2.};
+ TimeType const midTime{(time1 + time2) / 2.};
TimeType detectionTime1{time1 + newMidPaths[k].propagation_time_ -
n_source * betaTimesK * (time1 - midTime)};
TimeType detectionTime2{time2 + newMidPaths[k].propagation_time_ -
@@ -153,7 +153,7 @@ namespace corsika {
double const n_source{midPaths[i].refractive_index_source_};
double const betaTimesK{beta.dot(midPaths[i].emit_)};
- TimeType midTime{(startTime + endTime) / 2};
+ TimeType const midTime{(startTime + endTime) / 2};
TimeType detectionTime1{startTime + midPaths[i].propagation_time_ -
n_source * betaTimesK * (startTime - midTime)};
TimeType detectionTime2{endTime + midPaths[i].propagation_time_ -
diff --git a/corsika/detail/modules/radio/detectors/RadioDetector.inl b/corsika/detail/modules/radio/detectors/RadioDetector.inl
index a4128b80f..b37e8eafe 100644
--- a/corsika/detail/modules/radio/detectors/RadioDetector.inl
+++ b/corsika/detail/modules/radio/detectors/RadioDetector.inl
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* See file AUTHORS for a list of contributors.
*
diff --git a/corsika/detail/modules/radio/propagators/RadioPropagator.inl b/corsika/detail/modules/radio/propagators/RadioPropagator.inl
index 23fdabbe6..e5c65f97e 100644
--- a/corsika/detail/modules/radio/propagators/RadioPropagator.inl
+++ b/corsika/detail/modules/radio/propagators/RadioPropagator.inl
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
@@ -12,7 +12,7 @@
namespace corsika {
template <typename TImpl, typename TEnvironment>
- inline RadioPropagator<TImpl, TEnvironment>::RadioPropagator(const TEnvironment& env)
+ inline RadioPropagator<TImpl, TEnvironment>::RadioPropagator(TEnvironment const& env)
: env_(env) {}
} // namespace corsika
diff --git a/corsika/detail/modules/radio/propagators/SignalPath.inl b/corsika/detail/modules/radio/propagators/SignalPath.inl
index 52ff8cbbf..ceb189335 100644
--- a/corsika/detail/modules/radio/propagators/SignalPath.inl
+++ b/corsika/detail/modules/radio/propagators/SignalPath.inl
@@ -13,10 +13,10 @@
namespace corsika {
inline SignalPath::SignalPath(
- const TimeType propagation_time, const double average_refractive_index,
- const double refractive_index_source, const double refractive_index_destination,
- const Vector<dimensionless_d> emit, const Vector<dimensionless_d> receive,
- const LengthType R_distance, const std::deque<Point>& points)
+ TimeType const propagation_time, double const average_refractive_index,
+ double const refractive_index_source, double const refractive_index_destination,
+ Vector<dimensionless_d> const& emit, Vector<dimensionless_d> const& receive,
+ LengthType const R_distance, std::deque<Point> const& points)
: Path(points)
, propagation_time_(propagation_time)
, average_refractive_index_(average_refractive_index)
diff --git a/corsika/detail/modules/radio/propagators/SimplePropagator.inl b/corsika/detail/modules/radio/propagators/SimplePropagator.inl
index 497618548..410187898 100644
--- a/corsika/detail/modules/radio/propagators/SimplePropagator.inl
+++ b/corsika/detail/modules/radio/propagators/SimplePropagator.inl
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
@@ -12,13 +12,13 @@
namespace corsika {
template <typename TEnvironment>
- inline SimplePropagator<TEnvironment>::SimplePropagator(const TEnvironment& env)
+ inline SimplePropagator<TEnvironment>::SimplePropagator(TEnvironment const& env)
: RadioPropagator<SimplePropagator, TEnvironment>(env){};
template <typename TEnvironment>
inline typename SimplePropagator<TEnvironment>::SignalPathCollection
- SimplePropagator<TEnvironment>::propagate(const Point& source, const Point& destination,
- const LengthType stepsize) const {
+ SimplePropagator<TEnvironment>::propagate(Point const& source, Point const& destination,
+ LengthType const stepsize) const {
/**
* This is the simplest case of straight propagator
@@ -28,11 +28,11 @@ namespace corsika {
*/
// these are used for the direction of emission and reception of signal at the antenna
- auto emit_{(destination - source).normalized()};
- auto receive_{-emit_};
+ auto const emit_{(destination - source).normalized()};
+ auto const receive_{-emit_};
// the geometrical distance from the point of emission to an observer
- auto distance_{(destination - source).getNorm()};
+ auto const distance_{(destination - source).getNorm()};
// get the universe for this environment
auto const* const universe{Base::env_.getUniverse().get()};
@@ -45,22 +45,22 @@ namespace corsika {
rindex.reserve(2);
// get and store the refractive index of the first point 'source'.
- auto const* nodeSource{universe->getContainingNode(source)};
+ auto const* const nodeSource{universe->getContainingNode(source)};
auto const ri_source{nodeSource->getModelProperties().getRefractiveIndex(source)};
rindex.push_back(ri_source);
points.push_back(source);
// add the refractive index of last point 'destination' and store it.
- auto const* node{universe->getContainingNode(destination)};
+ auto const* const node{universe->getContainingNode(destination)};
auto const ri_destination{node->getModelProperties().getRefractiveIndex(destination)};
rindex.push_back(ri_destination);
points.push_back(destination);
// compute the average refractive index.
- auto averageRefractiveIndex_ = (ri_source + ri_destination) / 2;
+ auto const averageRefractiveIndex_ = (ri_source + ri_destination) / 2;
// compute the total time delay.
- TimeType time = averageRefractiveIndex_ * (distance_ / constants::c);
+ TimeType const time = averageRefractiveIndex_ * (distance_ / constants::c);
return {SignalPath(time, averageRefractiveIndex_, ri_source, ri_destination, emit_,
receive_, distance_, points)};
diff --git a/corsika/detail/modules/radio/propagators/StraightPropagator.inl b/corsika/detail/modules/radio/propagators/StraightPropagator.inl
index 1bee93674..9962fc133 100644
--- a/corsika/detail/modules/radio/propagators/StraightPropagator.inl
+++ b/corsika/detail/modules/radio/propagators/StraightPropagator.inl
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
@@ -13,16 +13,16 @@ namespace corsika {
template <typename TEnvironment>
// TODO: maybe the constructor doesn't take any arguments for the environment (?)
- inline StraightPropagator<TEnvironment>::StraightPropagator(const TEnvironment& env)
+ inline StraightPropagator<TEnvironment>::StraightPropagator(TEnvironment const& env)
: RadioPropagator<StraightPropagator, TEnvironment>(env){};
template <typename TEnvironment>
inline typename StraightPropagator<TEnvironment>::SignalPathCollection
- StraightPropagator<TEnvironment>::propagate(const Point& source,
- const Point& destination,
- const LengthType stepsize) const {
+ StraightPropagator<TEnvironment>::propagate(Point const& source,
+ Point const& destination,
+ LengthType const stepsize) const {
- /**
+ /*
* get the normalized (unit) vector from `source` to `destination'.
* this is also the `emit` and `receive` vectors in the SignalPath class.
* in this case emit and receive unit vectors should be the same
@@ -30,20 +30,20 @@ namespace corsika {
*/
// these are used for the direction of emission and reception of signal at the antenna
- auto emit_{(destination - source).normalized()};
- auto receive_{-emit_};
+ auto const emit_{(destination - source).normalized()};
+ auto const receive_{-emit_};
// the distance from the point of emission to an observer
- auto distance_{(destination - source).getNorm()};
+ auto const distance_{(destination - source).getNorm()};
try {
if (stepsize <= 0.5 * distance_) {
// "step" is the direction vector with length `stepsize`
- auto step{emit_ * stepsize};
+ auto const step{emit_ * stepsize};
// calculate the number of points (roughly) for the numerical integration
- auto n_points{(destination - source).getNorm() / stepsize};
+ auto const n_points{(destination - source).getNorm() / stepsize};
// get the universe for this environment
auto const* const universe{Base::env_.getUniverse().get()};
@@ -56,7 +56,7 @@ namespace corsika {
rindex.reserve(n_points);
// get and store the refractive index of the first point 'source'
- auto const* nodeSource{universe->getContainingNode(source)};
+ auto const* const nodeSource{universe->getContainingNode(source)};
auto const ri_source{nodeSource->getModelProperties().getRefractiveIndex(source)};
rindex.push_back(ri_source);
points.push_back(source);
@@ -67,7 +67,7 @@ namespace corsika {
point = point + step) {
// get the environment node at this specific 'point'
- auto const* node{universe->getContainingNode(point)};
+ auto const* const node{universe->getContainingNode(point)};
// get the associated refractivity at 'point'
auto const refractive_index{
@@ -83,7 +83,7 @@ namespace corsika {
auto const extrapoint_{points.back() + step};
// add the refractive index of last point 'destination' and store it
- auto const* node{universe->getContainingNode(destination)};
+ auto const* const node{universe->getContainingNode(destination)};
auto const ri_destination{
node->getModelProperties().getRefractiveIndex(destination)};
// auto const ri_destination{1.000327};
@@ -98,7 +98,7 @@ namespace corsika {
if ((N - 1) % 2 == 0) {
// Apply the standard Simpson's rule
- auto h = ((destination - source).getNorm()) / (N - 1);
+ auto const h = ((destination - source).getNorm()) / (N - 1);
for (std::size_t index = 1; index < (N - 1); index += 2) {
sum += 4 * rindex.at(index);
@@ -118,19 +118,19 @@ namespace corsika {
// Apply Simpson's rule for one "extra" point and then subtract the difference
points.pop_back();
rindex.pop_back();
- auto const* node{universe->getContainingNode(extrapoint_)};
+ auto const* const node{universe->getContainingNode(extrapoint_)};
auto const ri_extrapoint{
node->getModelProperties().getRefractiveIndex(extrapoint_)};
rindex.push_back(ri_extrapoint);
points.push_back(extrapoint_);
auto const extrapoint2_{extrapoint_ + step};
- auto const* node2{universe->getContainingNode(extrapoint2_)};
+ auto const* const node2{universe->getContainingNode(extrapoint2_)};
auto const ri_extrapoint2{
node2->getModelProperties().getRefractiveIndex(extrapoint2_)};
rindex.push_back(ri_extrapoint2);
points.push_back(extrapoint2_);
N = rindex.size();
- auto h = ((extrapoint2_ - source).getNorm()) / (N - 1);
+ auto const h = ((extrapoint2_ - source).getNorm()) / (N - 1);
for (std::size_t index = 1; index < (N - 1); index += 2) {
sum += 4 * rindex.at(index);
refra_ += rindex.at(index);
@@ -153,7 +153,7 @@ namespace corsika {
// TimeType time = ri_destination * (distance_ / constants::c);
// compute the average refractive index.
- auto averageRefractiveIndex_ = refra_ / N;
+ auto const averageRefractiveIndex_ = refra_ / N;
return {SignalPath(time, averageRefractiveIndex_, ri_source, ri_destination,
emit_, receive_, distance_, points)};
diff --git a/corsika/framework/core/PhysicalUnits.hpp b/corsika/framework/core/PhysicalUnits.hpp
index 0bafaedd8..ca78a9c91 100644
--- a/corsika/framework/core/PhysicalUnits.hpp
+++ b/corsika/framework/core/PhysicalUnits.hpp
@@ -100,8 +100,8 @@ namespace corsika::units::si {
phys::units::quantity<phys::units::dimensions<1, 1, -3, -1>, double>;
using VectorPotentialType =
phys::units::quantity<phys::units::dimensions<1, 1, -2, -1>, double>;
- using MagneticFieldType =
- phys::units::quantity<phys::units::dimensions<-1, 0, 0, 1>, double>;
+// using MagneticFieldType =
+// phys::units::quantity<phys::units::dimensions<-1, 0, 0, 1>, double>;
template <typename DimFrom, typename DimTo>
auto constexpr conversion_factor_HEP_to_SI() {
diff --git a/corsika/modules/TimeCut.hpp b/corsika/modules/TimeCut.hpp
index c931fe66a..605458293 100644
--- a/corsika/modules/TimeCut.hpp
+++ b/corsika/modules/TimeCut.hpp
@@ -27,7 +27,7 @@ namespace corsika {
template <typename Particle, typename Track>
ProcessReturn doContinuous(
- Particle& vParticle, Track const& vTrajectory,
+ Particle const& vParticle, Track const& vTrajectory,
const bool limitFlag = false); // this is not used for TimeCut
template <typename Particle, typename Track>
LengthType getMaxStepLength(Particle const&, Track const&) {
diff --git a/corsika/modules/radio/CoREAS.hpp b/corsika/modules/radio/CoREAS.hpp
index 108371945..1b78447e1 100644
--- a/corsika/modules/radio/CoREAS.hpp
+++ b/corsika/modules/radio/CoREAS.hpp
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
diff --git a/corsika/modules/radio/RadioProcess.hpp b/corsika/modules/radio/RadioProcess.hpp
index 904ebc59d..f0fa32d9f 100644
--- a/corsika/modules/radio/RadioProcess.hpp
+++ b/corsika/modules/radio/RadioProcess.hpp
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
@@ -30,10 +30,7 @@ namespace corsika {
RadioProcess<TAntennaCollection, TRadioImpl, TPropagator>>,
public BaseOutput {
- // using ParticleType = corsika::setup::Stack::particle_type;
- // using TrackType = corsika::LeapFrogTrajectory;
-
- /**
+ /*
* A collection of filter objects for deciding on valid particles and tracks.
*/
// std::vector<std::function<bool(ParticleType&, TrackType const&)>> filters_;
@@ -43,7 +40,7 @@ namespace corsika {
*/
TRadioImpl& implementation();
- /*
+ /**
* Get a const reference to the underlying implementation.
*/
TRadioImpl const& implementation() const;
diff --git a/corsika/modules/radio/ZHS.hpp b/corsika/modules/radio/ZHS.hpp
index c39df0af4..5e4bd50c6 100644
--- a/corsika/modules/radio/ZHS.hpp
+++ b/corsika/modules/radio/ZHS.hpp
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
diff --git a/corsika/modules/radio/detectors/RadioDetector.hpp b/corsika/modules/radio/detectors/RadioDetector.hpp
index d7d44da43..aa2d00868 100644
--- a/corsika/modules/radio/detectors/RadioDetector.hpp
+++ b/corsika/modules/radio/detectors/RadioDetector.hpp
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2018 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* See file AUTHORS for a list of contributors.
*
diff --git a/corsika/modules/radio/propagators/RadioPropagator.hpp b/corsika/modules/radio/propagators/RadioPropagator.hpp
index a7395b7be..599ada07f 100644
--- a/corsika/modules/radio/propagators/RadioPropagator.hpp
+++ b/corsika/modules/radio/propagators/RadioPropagator.hpp
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
diff --git a/corsika/modules/radio/propagators/SignalPath.hpp b/corsika/modules/radio/propagators/SignalPath.hpp
index 0a1c87005..59ce63e0d 100644
--- a/corsika/modules/radio/propagators/SignalPath.hpp
+++ b/corsika/modules/radio/propagators/SignalPath.hpp
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
@@ -25,14 +25,14 @@ namespace corsika {
double const average_refractive_index_; ///< The average refractive index.
double const refractive_index_source_; ///< The refractive index at the source.
double const
- refractive_index_destination_; ///< The refractive index at the destination point.
+ refractive_index_destination_; ///< The refractive index at the destination point.
Vector<dimensionless_d> const emit_; ///< The (unit-length) emission vector.
Vector<dimensionless_d> const receive_; ///< The (unit-length) receive vector.
std::deque<Point> const
- points_; ///< A collection of points that make up the geometrical path.
+ points_; ///< A collection of points that make up the geometrical path.
LengthType const
- R_distance_; ///< The distance from the point of emission to an observer. TODO:
- ///< optical path, not geometrical! (probably)
+ R_distance_; ///< The distance from the point of emission to an observer. TODO:
+ ///< optical path, not geometrical! (probably)
/**
* Create a new SignalPath instance.
@@ -40,7 +40,7 @@ namespace corsika {
SignalPath(TimeType const propagation_time, double const average_refractive_index,
double const refractive_index_source,
double const refractive_index_destination,
- Vector<dimensionless_d> const emit, Vector<dimensionless_d> const receive,
+ Vector<dimensionless_d> const& emit, Vector<dimensionless_d> const& receive,
LengthType const R_distance, std::deque<Point> const& points);
}; // END: class SignalPath final
diff --git a/corsika/modules/radio/propagators/SimplePropagator.hpp b/corsika/modules/radio/propagators/SimplePropagator.hpp
index 35d567941..33c402774 100644
--- a/corsika/modules/radio/propagators/SimplePropagator.hpp
+++ b/corsika/modules/radio/propagators/SimplePropagator.hpp
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
diff --git a/corsika/modules/radio/propagators/StraightPropagator.hpp b/corsika/modules/radio/propagators/StraightPropagator.hpp
index 7d79f8176..d6c156336 100644
--- a/corsika/modules/radio/propagators/StraightPropagator.hpp
+++ b/corsika/modules/radio/propagators/StraightPropagator.hpp
@@ -1,5 +1,5 @@
/*
- * (c) Copyright 2020 CORSIKA Project, corsika-project@lists.kit.edu
+ * (c) Copyright 2022 CORSIKA Project, corsika-project@lists.kit.edu
*
* This software is distributed under the terms of the GNU General Public
* Licence version 3 (GPL Version 3). See file LICENSE for a full version of
--
GitLab