From 3d5f8fc7c0dd2d4f0dbd7fd20f0a9cd4feaa93cc Mon Sep 17 00:00:00 2001
From: Nikos Karastathis <n.karastathis@kit.edu>
Date: Fri, 9 Jun 2023 16:34:01 +0200
Subject: [PATCH] weight from thinning should be multiplied in electric field
vectors and vector potentials
---
corsika/detail/modules/radio/CoREAS.inl | 7 +++++--
corsika/detail/modules/radio/ZHS.inl | 5 ++++-
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/corsika/detail/modules/radio/CoREAS.inl b/corsika/detail/modules/radio/CoREAS.inl
index f79a0f8d7..317d3febf 100644
--- a/corsika/detail/modules/radio/CoREAS.inl
+++ b/corsika/detail/modules/radio/CoREAS.inl
@@ -46,9 +46,12 @@ namespace corsika {
// get particle charge
auto const charge_{get_charge(step.getParticlePre().getPID())};
+ // get thinning weight
+ auto const thinningWeight{step.getParticlePre().getWeight()};
+
// constants for electric field vector calculation
- auto const constants_{charge_ / (4 * M_PI) / (constants::epsilonZero) /
- constants::c};
+ auto const constants_{(charge_ / (4 * M_PI) / (constants::epsilonZero) /
+ constants::c) * thinningWeight};
// set threshold for application of ZHS-like approximation.
const double approxThreshold_{1.0e-3};
diff --git a/corsika/detail/modules/radio/ZHS.inl b/corsika/detail/modules/radio/ZHS.inl
index 6b8b4907a..db6971c5f 100644
--- a/corsika/detail/modules/radio/ZHS.inl
+++ b/corsika/detail/modules/radio/ZHS.inl
@@ -41,7 +41,10 @@ namespace corsika {
auto const halfVector{(startPoint - endPoint) / 2};
auto const midPoint{endPoint + halfVector};
- auto const constants{charge / (4 * M_PI) / (constants::epsilonZero) / constants::c};
+ // get thinning weight
+ auto const thinningWeight{step.getParticlePre().getWeight()};
+
+ auto const constants{(charge / (4 * M_PI) / (constants::epsilonZero) / constants::c) * thinningWeight};
// we loop over each antenna in the collection
for (auto& antenna : antennas_.getAntennas()) {
--
GitLab