diff --git a/Environment/HomogeneousMedium.h b/Environment/HomogeneousMedium.h index 566b565e7ed4b7d03f37cf9a4a7c0baf7b232409..cc612d044cb8c1d3f2d96ec081894806e6ab6dad 100644 --- a/Environment/HomogeneousMedium.h +++ b/Environment/HomogeneousMedium.h @@ -42,14 +42,14 @@ namespace corsika::environment { NuclearComposition const& GetNuclearComposition() const override { return fNuclComp; } corsika::units::si::GrammageType IntegratedGrammage( - corsika::geometry::Trajectory<corsika::geometry::Line> const& pTraj, + corsika::geometry::Trajectory<corsika::geometry::Line> const&, corsika::units::si::LengthType pTo) const override { using namespace corsika::units::si; return pTo * fDensity; } corsika::units::si::LengthType ArclengthFromGrammage( - corsika::geometry::Trajectory<corsika::geometry::Line> const& pTraj, + corsika::geometry::Trajectory<corsika::geometry::Line> const&, corsika::units::si::GrammageType pGrammage) const override { return pGrammage / fDensity; } diff --git a/Framework/Cascade/Cascade.h b/Framework/Cascade/Cascade.h index a94de8bb15d006447f8ad25d48215c69e8d6f8ec..31c16e2eab8164db2598c9149409cd5dc7900f76 100644 --- a/Framework/Cascade/Cascade.h +++ b/Framework/Cascade/Cascade.h @@ -58,14 +58,11 @@ namespace corsika::cascade { void Step(Particle& particle) { + using namespace corsika::units::si; using std::cout; using std::endl; using std::log; - // get access to random number generator - static corsika::random::RNG& rmng = - corsika::random::RNGManager::GetInstance().GetRandomStream("s_rndm"); - // determine geometric tracking corsika::setup::Trajectory step = fTracking.GetTrack(particle); @@ -105,7 +102,7 @@ namespace corsika::cascade { // Environment::GetDistance(step, next_decay); LengthType const distance_decay = next_decay * particle.GetMomentum().norm() / particle.GetEnergy() * - corsika::units::si::constants::cSquared; + corsika::units::constants::c; // take minimum of geometry, interaction, decay for next step auto const min_distance = @@ -160,10 +157,10 @@ namespace corsika::cascade { } private: + corsika::environment::Environment const& fEnvironment; Tracking& fTracking; ProcessList& fProcessSequence; Stack& fStack; - corsika::environment::Environment const& fEnvironment; corsika::random::RNG& fRNG = corsika::random::RNGManager::GetInstance().GetRandomStream("cascade"); }; diff --git a/Framework/Units/PhysicalUnits.h b/Framework/Units/PhysicalUnits.h index 7565c6035dc1f5de4f3a3f061166c2ac1d3f2cd0..1ad2d6428ef870aeaccd3fd55400d8e03a5ab2bf 100644 --- a/Framework/Units/PhysicalUnits.h +++ b/Framework/Units/PhysicalUnits.h @@ -95,8 +95,8 @@ namespace phys { QUANTITY_DEFINE_SCALING_LITERALS(eV, energy_d, magnitude(corsika::units::constants::eV)) - // QUANTITY_DEFINE_SCALING_LITERALS(barn, corsika::units::si::area_d, - // magnitude(corsika::units::si::constants::barn)) + // QUANTITY_DEFINE_SCALING_LITERALS(barn, corsika::units::si::area_d, + // magnitude(corsika::units::si::constants::barn)) QUANTITY_DEFINE_SCALING_LITERALS(barn, corsika::units::si::sigma_d, magnitude(corsika::units::constants::barn)) diff --git a/Processes/Sibyll/Interaction.h b/Processes/Sibyll/Interaction.h index 9a5ad9b38a6da85c144b019cf6cf67e3101c844e..a82dac38034c26a6373fe6ff07a4a278dcdb400e 100644 --- a/Processes/Sibyll/Interaction.h +++ b/Processes/Sibyll/Interaction.h @@ -11,7 +11,6 @@ #include <corsika/random/RNGManager.h> #include <corsika/units/PhysicalUnits.h> - namespace corsika::process::sibyll { class Interaction : public corsika::process::InteractionProcess<Interaction> { @@ -117,7 +116,6 @@ namespace corsika::process::sibyll { return int_length; } - return std::numeric_limits<double>::infinity() * 1_g / (1_cm * 1_cm); /* diff --git a/Processes/Sibyll/SibStack.h b/Processes/Sibyll/SibStack.h index 12da1bddb8f18ef83a2a4d7219a3ab4d8d29a852..7398d40003402d3c45aa83c4b2fc0eae2e9d1fa3 100644 --- a/Processes/Sibyll/SibStack.h +++ b/Processes/Sibyll/SibStack.h @@ -12,8 +12,6 @@ namespace corsika::process::sibyll { typedef corsika::geometry::Vector<corsika::units::hep::energy_hep_d> MomentumVector; -namespace corsika::process::sibyll { - class SibStackData { public: @@ -34,8 +32,7 @@ namespace corsika::process::sibyll { using namespace corsika::units; using namespace corsika::units::hep; auto tmp = v.GetComponents(); - for (int idx = 0; idx < 3; ++idx) - s_plist_.p[idx][i] = tmp[idx] / 1_GeV; + for (int idx = 0; idx < 3; ++idx) s_plist_.p[idx][i] = tmp[idx] / 1_GeV; } int GetId(const int i) const { return s_plist_.llist[i]; }